Fixes #13459: Removed tags that accept multiple args from array helper #13695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronHall
force-pushed
the
bugfix/volt-tag-array-helper
branch
2 times, most recently
from
c42a28d
to
7fe7393
Compare
CameronHall
force-pushed
the
bugfix/volt-tag-array-helper
branch
from
7fe7393
to
268da75
Compare
|
@niden this one is also ready for review :) |
…y helper Removed `select`, and `select_static` from array helper.
CameronHall
force-pushed
the
bugfix/volt-tag-array-helper
branch
from
268da75
to
eb2e482
Compare
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13695 +/- ##
==========================================
- Coverage 66.08% 66.08% -0.01%
==========================================
Files 396 396
Lines 88253 88251 -2
==========================================
- Hits 58321 58319 -2
Misses 29932 29932
Continue to review full report at Codecov.
|
niden
approved these changes
Jan 12, 2019
|
@CameronHall Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: Removed
select, andselect_staticfrom array helper in Volt compiler as they accept multiple arguments which can cause the issue presented in #13459Thanks