Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T12379 html tag #13656

Merged
merged 21 commits into from
Dec 11, 2018
Merged

T12379 html tag #13656

merged 21 commits into from
Dec 11, 2018

Conversation

niden
Copy link
Member

@niden niden commented Dec 11, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Created new component Phalcon\Html\Tag. It duplicates the functionality of Phalcon\Tag but does not use static calls (it has to be instantiated).

All credits go to @SidRoberts Sadly we could not cherry pick #12379. Instead of doing a full replacement of the current Tag component, we created this one to give the community more time to adapt to the new one.

Thanks

@niden
[#12379] - Added .zephir folder in the gitignore
f06c1c2
@niden
[#12379] - Added new component and base methods
b62fcbe
@niden
[#12379] - Added test stubs
e660cb7
@niden
[#12379] - Renamed the methods; Rearranged the test stubs
bc70a4c
@niden
[#12379] - Work on the elementClose
9625c85
@niden
[#12379] - More work on the component and tests
1bd58e1
@niden
[#12379] - Reworking the tag; Slowly adding more functionality; Corre…
4555523 
…cted tests
@niden
[#12379] - More Html\Tag tests
00fe02b
@niden
[#12379] - Work on the component Html\Tag
0dd4a0d
@niden
[#12379] - Docblocks
f941589
@niden
[#12379] - Corrections to the tag; Added more tests
b6c5fc7
@niden
[#12379] - PHPCS
8eb2be0
@niden
[#12379] - Merge branch '4.0.x' into T12379-html-tag
f7e2b16 
* 4.0.x:
  Fixed failing Postgresql test
  Updated Changelog
  Update postgresql.zep
  Update README.md
@niden
[#12379] - Merge branch '4.0.x' into T12379-html-tag
d55ef45 
* 4.0.x:
  Fixed styling using phpcbf
  Fixed intergrations tests
  [#13491] - Corrected interfaces
@niden
[#12379] - Added Html\Tag select functionality; select static tests; …
255a1fe 
…link tests
@niden
[#12379] - Corrections; Work on image; Added more tests
2454b26
@niden
[#12379] - Removed obsolete test stubs
42507f1
@niden niden added the new feature request Planned Feature or New Feature Request label Dec 11, 2018
@niden
Copy link
Member Author

niden commented Dec 11, 2018

cc @sergeyklay

sergeyklay
sergeyklay reviewed Dec 11, 2018
View reviewed changes
.gitignore Show resolved Hide resolved
sergeyklay
sergeyklay reviewed Dec 11, 2018
View reviewed changes
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
sergeyklay
sergeyklay approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niden niden merged commit 842d06f into phalcon:4.0.x Dec 11, 2018
@niden niden mentioned this pull request Dec 11, 2018
Closed
@niden niden deleted the T12379-html-tag branch January 21, 2019 19:19
@niden niden added the documentation Documentation required label Apr 9, 2019
@SidRoberts SidRoberts mentioned this pull request May 2, 2019
Closed
3 tasks
@niden niden added 4.0 and removed documentation Documentation required labels Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay