Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Flash\Session::isset() #1356

Merged
merged 3 commits into from Oct 10, 2013
Merged

Phalcon\Flash\Session::isset() #1356

merged 3 commits into from Oct 10, 2013

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2013

See #1342

@phalcon
Copy link
Collaborator

phalcon commented Oct 9, 2013

A method cannot be named 'isset' because it's a reserved word, could we use 'has' instead?

@ghost
Copy link
Author

ghost commented Oct 10, 2013

Interesting… Looks like isset() cannot be used by PHP classes but can be used by Zend classes.

@ghost
Copy link
Author

ghost commented Oct 10, 2013

Done

phalcon pushed a commit that referenced this pull request Oct 10, 2013
Phalcon\Flash\Session::isset()
@phalcon phalcon merged commit ed7ad58 into phalcon:1.3.0 Oct 10, 2013
@phalcon
Copy link
Collaborator

phalcon commented Oct 10, 2013

Thanks!

@ghost ghost deleted the issue-1342 branch October 10, 2013 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants