-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFR] Added json dataType support for MySQL dialect. #13225
Conversation
MySQL version >= 5.7. = =! |
Is this expected for 3.3.2, or will it be in 4.x? |
I apologize @zGaron for completely overlooking this. Thank you for the PR. Could you please send this PR to the 4.0.x branch? And again I am sorry about the delay. |
To clarify --- does this mean one can bind native PHP arrays that automatically get transformed into or from JSON at the DB layer? e.g. does the following work? This is what I would expect: ( I didn't see any code changes or tests that would test this?)
DB
|
@virgofx I think so |
I believe Since PDO doesn't bind native JSON ... I would think somewhere in the Phalcon PHQL/database layer I was expecting to see json_encode()/json_decode() just prior to save --- I didn't see that ... At least a test to outline above showing that it works would also be good. |
This should be on the top of all lists. |
@virgofx I don't think that there is an automatic conversion towards a
@zGaron would you be so kind as to rebase this and send it to the 4.0.x branch? Thank you |
Addressed in #13562 |
Hello!
instead of PR #13216
Small description of change:
Thanks