-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests + test coverage #1307
Conversation
It seems that we now have 3 unit-test suite-cases Can we do something ASAP to unify them? |
Tests in ext/tests are for package maintainers so that they can use I see there is php-tests directory but it does not seem to be used. |
The php-tests is the new test suite. |
So should I put all new tests there? Otherwise we will end up doing duplicate job if we need to migrate the existing test cases into php-tests. |
Sure thing! I was migrating some of them over but then things got crazy at work .... you know the drill :) |
Looks a bit sad:
|
I think I need to revert d89c1de — PHPUnit uses wrong php-cgi binary to run the test and this is why the build fails. |
In this PR:
The most interesting part is "test coverage".
Now Phalcon can be build with --enable-coverage key, ie
This requires
lcov
andgenhtml
programs (apt-get install lcov
in Debian and Ubuntu).To get the test coverage, run
This will run regression tests, unit tests and then produce test coverage information in
coverage/
directory (opencoverage/index.html
in the browser to view the details).This is what the report looks like: https://www.diigo.com/item/image/3zdqq/hjpw
This can be useful if someone wants to write more tests as it shows completely grey areas not covered by any tests.