Added describeReferences method in postgresql DB #12969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use phql bracket escaping instead of double quotes Escape raw SQL portion with double quotes changelog update added delimiters to escape reserved words in getPaginate
sergeysviridenko
force-pushed
the
3.2.create_reference
branch
from
f3fa946 to
a9e4863
Compare
sergeysviridenko
force-pushed
the
3.2.create_reference
branch
from
a9e4863 to
92bd55f
Compare
3 tasks
|
Your file phalcon/db/adapter/pdo/postgresql.zep is still missing already merged and approved changes in #12962 |
sergeyklay
suggested changes
Jul 19, 2017
Added a test for issue 12957
escape rowcount alias
Fixed memory leaks
…halcon into 3.2.create_reference
…halcon into 3.2.create_reference
…halcon into 3.2.create_reference
|
Could you please submit just the commits that belong to the PR? |
|
This PR I'll close. New PR with rebased branch #12982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Phalcon\Db\Dialect\Postgresql::describeReferencesto generate correct SQLPhalcon\Db\Adapter\Pdo\Postgresql::describeReferencesfor proper creatingReferenceobject phalcon/phalcon-devtools#438Thanks