Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalid element name #12954

Merged
merged 4 commits into from
Aug 6, 2017
Merged

Prevent invalid element name #12954

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f202c8
Prevent invalid element name
emiliodeg Jul 11, 2017
f6c8a59
trim name
emiliodeg Jul 13, 2017
f6b31a8
Update element.zep
emiliodeg Jul 13, 2017
e0864cf
Update element.zep
emiliodeg Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update element.zep
  • Loading branch information
@emiliodeg
emiliodeg authored Jul 13, 2017
commit f6b31a8fcc7676fb1ec7193e21af863a8ad2e780
2 changes: 1 addition & 1 deletion phalcon/forms/element.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ abstract class Element implements ElementInterface
*/
public function __construct(string name, var attributes = null)
{
let name = trim(name)
let name = trim(name);

if empty name {
throw new \InvalidArgumentException('Form element name is required');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new \InvalidArgumentException('...'); =>throw new \InvalidArgumentException("...");

Expand Down