Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] Response headers and cookies are no longer prematurely sent #12378

Merged
merged 3 commits into from
Aug 15, 2017
Merged

[4.0.0] Response headers and cookies are no longer prematurely sent #12378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec7c52d
Response headers and cookies are no longer prematurely sent.
SidRoberts Aug 1, 2017
2ddfa55
Updated changelog [ci skip]
SidRoberts Aug 15, 2017
00723b8
Merge branch '4.0.x' into v4-response-premature-send
sergeyklay Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# [4.0.0](https://github.com/phalcon/cphalcon/releases/tag/v4.0.0) (2017-XX-XX)
- MVC Application and Router now must have a URI to process [#12380](https://github.com/phalcon/cphalcon/pull/12380)
- Response headers and cookies are no longer prematurely sent [#12378](https://github.com/phalcon/cphalcon/pull/12378)
6 changes: 0 additions & 6 deletions phalcon/mvc/application.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,6 @@ class Application extends BaseApplication
eventsManager->fire("application:beforeSendResponse", this, response);
}

/**
* Headers and Cookies are automatically sent
*/
response->sendHeaders();
response->sendCookies();

/**
* Return the response
*/
Expand Down