Fix appendTitle, prependTitle. Update unit test for append, prepend and setTitle.

[borisdelev]

Update tests for prependTitle and appendTitle functions.
For details: #12233

Update test for setTitle and getTitle: Make sure that getTitle(false) did not return <title> tag element

[borisdelev]

Hope i make it right now. Sorry for my mistakes :/

[virgofx]

Unit tests look fine ... can we get can update though for the actual Tag implementation so this will pass?

[borisdelev]

@virgofx i will try to make this changes too...

[sergeyklay]

@butamuh4o As you can see tests fails

[borisdelev]

@sergeyklay I want to ask you to help me with something about a change i was trying to do. Can u check that and give me some details where and what is wrong with syntax? Thank you!!!

    /**
     * Prepends a text to current document title
     */
    public static function prependTitle(var title) -> void
    {
        var prepend = [];
        if self::_documentPrependTitle !== null {
            let prepend = self::_documentPrependTitle ;
        }

        if typeof title == array {
            let prepend = title;
        } else {
            if typeof title == string {
                array_unshift(prepend, title) ;
            }
        }

        if !empty prepend {
            let self::_documentPrependTitle = prepend ;
        }
    }

I want to give some freedom about prepend and append title functions. Maybe it is clear what i want to make: a way to clear prependTitle/appendTitle instead of clear all title elements.

Update: yes, i found my mistake! its that typeof. So stupid. Thanks

[sergeyklay]

This is new feature request?

[sergeyklay]

So now _documentPrependTitle is array or null and this breaking BC

[borisdelev]

No it is not change request. Just think it is better to have that option. Will revert that idea. Sorry

[sergeyklay]

It is good idea, but for 3.1.x not for 3.0.x

[sergeyklay]

@butamuh4o Also could you update CHANGELOG.md?

[borisdelev]

So i will make a clear pull request and update changelog. Just to get to the office. Thank you!

PS: sorry for that i closed this pull, my phone did that.