Phalcon\Mvc\Query\Builder's constructor sample code in comment + support...

[Cinderella-Man]

Hi,

I added support for defining 'offset' via constructor but there's many more to updated:

limit key could take array of 2 values (limit, offset) as the limit() method does limit (int $limit, [int $offset])

'conditions' key could take:
array(
array(string $conditions, [array $bindParams], [array $bindTypes])
)
or at least:
array(string $conditions, [array $bindParams], [array $bindTypes])

'having' key could work in the same way as 'conditions' but it could be simplified to single array(string $conditions, [array $bindParams], [array $bindTypes])

adding explicit DESC or ASC to 'order' value like that array('name DESC', 'id ASC') causes following exception thrown:
Uncaught exception 'Phalcon\Mvc\Model\Exception' with message 'Scanning error before 'name DESC], [id ...'

'models' key(added by me) could take also alias to be the same as addFrom (string $model, [string $alias])

lack of support for following: join, innejJoin, leftJoin, rightJoin, orWhere, betweenWhere, notBetweenWhere, inWhere, notInWhere.

PS. Why all those function aren't simply using methods of that class instead of setting them inside constructor?

PS. PS. On master branch there's still this 'having' typo which makes usage of 'having' key impossible.

I hope that all above makes sense and it' at least a little bit helpful.

Thanks,

Kamil

[phalcon]

Thanks!

[phalcon]

Regarding your questions:

Why all those function aren't simply using methods of that class instead of setting them inside constructor?

It's faster, call a method is expensive compared to update a property in the same class which it belongs