Improved Phalcon\Config\Adapter\Ini #11969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
👍 |
|
Thank you too |
|
This breaks parsing option values that have php constants in them? (due to use of INI_SCANNER_RAW, in which case option values are not parsed according to http://php.net/manual/en/function.parse-ini-file.php) This is a BC break (worked fine until this merge/commit) - might be a good idea to add it to the list of major incompatible changes somewhere... |
|
https://blog.phalconphp.com/post/phalcon-3-0-0-released
|
|
Hm, the blog post doesn't mention it (neither does the changelog)... Not really sure how to easily fix this yet, but I made a test which passes in 2.0.13 (and earlier) and fails in 3.0.0: zytzagoo@cb5af1f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.