[BUG] \Phalcon\Session\Flash::getMessages() #11941

[tugrul]

#11941

[Jurigag]

Isn't this fetch supposed to do what this if above is doing ? I think you only need to remove && isset(messages[type]) from original code.

[tugrul]

@Jurigag I'm not familiar to code Zephir. I looked up behavior of fetch operator and you are right.

Following block possibly better:

if typeof type == "string" {
    if fetch returnMessages, messages[type] {
        if remove === true {
            unset(messages[type]);
            session->set("_flashMessages", messages);
        }
        return returnMessages;
    }

    return [];
}

I'm going to commit this.

[sergeyklay]

We don't add changes directly to stable branches or master. Could you please send this PR to the 2.1.x branch?

[sergeyklay]

Fixed in the 2.1.x branch.