ORM: Case-insensitive column map option #11802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a global ORM setting that allows to try to find a key in column map case-insensitively if it was not found by an exact match at first time. Can be a real fix for many Oracle bugs, because Phalcon does not expect that column names are converted to uppercase by Oracle in the result.
| "orm.try_ci_column_map": { | ||
| "type": "bool", | ||
| "default": false | ||
| } | ||
| }, |
|
Could you please rebase? |
Added a global ORM setting that allows to try to find a key in column map case-insensitively if it was not found by an exact match at first time. Can be a real fix for many Oracle bugs, because Phalcon does not expect that column names are converted to uppercase by Oracle in the result.
…orm-colmap-ci # Conflicts: # CHANGELOG.md
Tabs -> spaces. Sorry for that.
|
@sergeyklay Tried to do the rebase, merge and fixing the indents. |
|
@Skydev0h ping |
3 tasks
|
Closed in favor of #13569 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a global ORM setting that allows to try to find a key in column map case-insensitively if it was not found by an exact match at first time. Can be a real fix for many Oracle bugs, because Phalcon does not expect that column names are converted to uppercase by Oracle in the query result.
This is a real fix for #10532, because orm.ignore_unknown_columns just suppresses error, while _groupResult will return NULL which may have unintended consequences, and of course Model::count() will not work in this case. This may be a fix for #1652, #760, #10490, but did not check all those cases yet.