NFR #1171 Adding code support validation messages #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 30, 2013 07:39
…ted into some parent method)
|
Alright, I think I've done what I was going to do. Can anyone please review and show me my mistakes? |
| @@ -153,7 +153,21 @@ | |||
|
|
|||
| PHALCON_INIT_VAR(type); | |||
| ZVAL_STRING(type, "Exclusion", 1); | |||
| phalcon_call_method_p3_noret(this_ptr, "appendmessage", message, field_name, type); | |||
|
|
|||
| // Is code set | |||
There was a problem hiding this comment.
Please use /* ... */ comments to make sure that the code can be compiled by a C89 compiler; // is an extension which is not supported by all compilers
|
Looks good to me, well done! |
|
Thank you, fixed |
phalcon
pushed a commit
that referenced
this pull request
Sep 1, 2013
NFR #1171 Adding code support validation messages
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.