Removed redundant validity checks DI and ModelsManager in Mvc\Model. #11496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
added a commit
that referenced
this pull request
Mar 6, 2016
…assignments Removed redundant validity checks DI and ModelsManager in Mvc\Model.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DI and the Models Manager are set in the constructor so we don't need to check if they are objects. See https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/model.zep#L134 and https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/model.zep#L145.