[2.0.x] Readded Http\Request::hasPut() (#10283)

[SidRoberts]

See #10283 and https://github.com/phalcon/cphalcon/blob/1.3.4/ext/http/request.c#L692

[Green-Cat]

👍

[sergeyklay]

@SidRoberts Can you please provide small test like https://github.com/phalcon/cphalcon/blob/master/tests/unit/Phalcon/Http/Request/HttpRequestTest.php#L401 ?

[SidRoberts]

@sergeyklay I've tried to write tests but as PUT data is taken from php://input, I can't think of a feasible way to test it. On the plus side, attempting to write tests made me realise $_PUT doesn't exist. 😛

[sergeyklay]

Another plus of testing

[andresgutierrez]

The contents of file_get_contents("php://input") must be cached in a property, because if you call it twice the second will return null

[sergeyklay]

Why not use define('PHP_INPUT', 'php://input') or something like that at start (bootstrap) time? :)

[andresgutierrez]

Could you please update the CHANGELOG?

[SidRoberts]

@andresgutierrez Done.

[andresgutierrez]

Thanks

[sergeyklay]

@SidRoberts

I can't think of a feasible way to test it.

stream_wrapper_unregister("php");
stream_wrapper_register("php", "your_awesome_stream_mock_class");
// ...
// tests
// ...
stream_wrapper_restore("php");