Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1022 1.3.0 #1027

Closed
wants to merge 165 commits into from
Closed

Bug 1022 1.3.0 #1027

Changes from 1 commit
Commits
Show all changes
165 commits
Select commit Hold shift + click to select a range
4beb87a
Updating README [ci skip]
andresgutierrez Jul 24, 2013
8ce9f0d
Added Phalcon\Cache\Backend\Libmemcached
Jul 24, 2013
533d450
Fix #903
sjinks Jul 25, 2013
e18a27c
The root memory frame survives across requests
sjinks Jul 24, 2013
9c7483f
Fix 'pointer targets differ in signedness' warning
sjinks Jul 25, 2013
e12bfdd
Fix bug in phalcon_escape_multi() introduced in 1ce094c60dd4a4ef674cb…
sjinks Jul 25, 2013
a3a4256
Fix #908
sjinks Jul 25, 2013
f8ac704
Implemented #885
sjinks Jul 25, 2013
1ca3198
Unit test
sjinks Jul 25, 2013
5ad9ddc
Fix #701
sjinks Jul 25, 2013
01f794d
Unit test
sjinks Jul 25, 2013
3622be4
Commented out listenLowSeverity()
sjinks Jul 25, 2013
5cec130
Merge pull request #912 from sjinks/mm
Jul 25, 2013
d75abcc
Merge pull request #917 from sjinks/issue-903
Jul 25, 2013
2304b52
Merge pull request #920 from sjinks/issue-908
Jul 25, 2013
210aa9a
Merge pull request #921 from sjinks/issue-885
Jul 25, 2013
010d15d
Merge pull request #922 from sjinks/issue-701
Jul 25, 2013
6fdc9c0
Merge pull request #913 from kjdev/1.3.0
Jul 25, 2013
46f3955
Fix invalid memory reads when GC is on
sjinks Jul 25, 2013
a729686
Fix #802
sjinks Jul 25, 2013
13b9318
Fix #910, 914
sjinks Jul 25, 2013
704a3c4
Do not restore stack too many times
sjinks Jul 25, 2013
07aeec0
Merge pull request #916 from sjinks/issue-802
Jul 25, 2013
c307a28
Merge pull request #927 from sjinks/garbage-collection
Jul 25, 2013
f68a620
Restore memory frames only on fatal errors
sjinks Jul 25, 2013
a5d8ebd
Merge pull request #928 from sjinks/clean-fatal
Jul 25, 2013
6661097
Merge pull request #918 from sjinks/phalcon_fetch_params
niden Jul 25, 2013
34e52da
description for
xboston Jul 25, 2013
b3f7e18
Bumped the version to 1.3.0.ALPHA.1 and regenerated build
niden Jul 25, 2013
4b4a3b4
Merge pull request #930 from xboston/1.3.0
niden Jul 25, 2013
78a62f8
Added Phalcon\Mvc\View __isset Magic method
Jul 25, 2013
9195d8b
Regenerated builds and moved a commit from master to this branch
niden Jul 25, 2013
e034f33
Merge branch '1.3.0' of github.com:phalcon/cphalcon into 1.3.0
niden Jul 25, 2013
3d6eb10
Merge pull request #931 from sjinks/issue-835
niden Jul 25, 2013
db4316e
Updated changelog for 1.2.2
sjinks Jul 25, 2013
58cf2d4
Use native functions wherever possible
sjinks Jul 26, 2013
bb5ffdb
Force Travis to upgrade Mongo PHP driver
sjinks Jul 26, 2013
2f48fa8
Merge pull request #936 from sjinks/native-funcs
Jul 26, 2013
e1a9e5a
Merge pull request #937 from sjinks/update-mongo-driver
Jul 27, 2013
a83a74b
Add Decimal scale
dreamsxin Jul 27, 2013
110e6b5
updated ext/db/adapter/pdo/postgresql.c
dreamsxin Jul 27, 2013
4f634b7
Support for self/parent/static properties
sjinks Jul 27, 2013
07c52ff
Native functions
sjinks Jul 27, 2013
01fc115
Merge pull request #943 from sjinks/read_class_property
Jul 27, 2013
44b65e7
Merge pull request #945 from sjinks/array_funcs
Jul 27, 2013
894e7bd
Do not duplicate checks performed in phalcon_create_instance_params()
sjinks Jul 27, 2013
767e9d0
Scope lookup optimizations
sjinks Jul 28, 2013
5473d22
Use zend_binary_strcasecmp() instead of memcmp()
sjinks Jul 28, 2013
d98baef
Less noise
sjinks Jul 28, 2013
98dd582
Bug fix
sjinks Jul 28, 2013
1104028
Removed Mongo hack
sjinks Jul 28, 2013
a2a74a4
Merge pull request #946 from sjinks/phalcon_create_instance_params
Jul 28, 2013
852ffd9
Merge pull request #948 from sjinks/lookup-scope
Jul 28, 2013
7afbc73
pecl automagically adds extension to php.ini
sjinks Jul 28, 2013
b70690c
More diagnostics on failure
sjinks Jul 28, 2013
54ee0fa
Fix Mongo
sjinks Jul 28, 2013
c86a827
Another attempt to fix Mongo
sjinks Jul 28, 2013
9535235
Removed Z_SET_ISREF_P
sjinks Jul 29, 2013
7a0c019
Merge pull request #940 from dreamsxin/decimal_scale_1.3.0
Jul 29, 2013
8704097
Merge pull request #949 from sjinks/travis-bugs
Jul 29, 2013
06d5033
Update README.md
Jul 29, 2013
b5197cc
Major rewrite
sjinks Jul 30, 2013
c3166d9
Fix bug #947
dreamsxin Jul 30, 2013
839105f
Do not efree() what we alloca()'d
sjinks Jul 30, 2013
23c19d6
Fixed typos
sjinks Jul 30, 2013
5c43852
Make use of interned strings
sjinks Jul 30, 2013
76eda34
Do not use emalloc() in phalcon_call_user_function()
sjinks Jul 30, 2013
3b33bc4
Add missing call to zend_inline_hash_func()
sjinks Jul 30, 2013
fb64615
Merge pull request #953 from dreamsxin/bug_947
Jul 30, 2013
3369218
Merge pull request #954 from sjinks/fcall
Jul 30, 2013
021646e
Update console.c
Jul 30, 2013
0671b9c
Merge pull request #956 from sjinks/console
Jul 31, 2013
9740336
Fix bug #951
dreamsxin Jul 31, 2013
a7f318e
Use phalcon_is_iterable() macro
sjinks Jul 31, 2013
1f46863
Fix #938
sjinks Jul 31, 2013
662351e
'New' means 'new', not 'clone'
sjinks Jul 31, 2013
eb5eb65
Update manager.h
dreamsxin Jul 31, 2013
a87701f
Added unit test
sjinks Jul 31, 2013
023d349
Fixed tests
sjinks Jul 31, 2013
b446b15
Bug fix
sjinks Jul 31, 2013
7c20afd
Typo fix
sjinks Jul 31, 2013
63886a2
Merge pull request #960 from sjinks/phalcon_is_iterable
Jul 31, 2013
eb03bec
Merge pull request #958 from dreamsxin/issues951_1.3.0
Jul 31, 2013
b67bc92
Merge pull request #959 from sjinks/issue-938
Jul 31, 2013
35fbb2a
Fix #942
sjinks Aug 1, 2013
6fa1247
Merge pull request #965 from sjinks/issue-942
Aug 1, 2013
81516a4
‘marker’ may be used uninitialized in this function
sjinks Aug 1, 2013
1b8d352
‘uidx’ may be used uninitialized in this function
sjinks Aug 1, 2013
ee7a8e8
‘regexp_length’ may be used uninitialized in this function
sjinks Aug 1, 2013
524be8c
variable may be used uninitialized in this function
sjinks Aug 1, 2013
7c4adf0
‘parser.tmp_state’ may be used uninitialized in this function
sjinks Aug 1, 2013
e640527
‘marker’ may be used uninitialized in this function
sjinks Aug 1, 2013
45f166f
‘phql_key’ may be used uninitialized in this function
sjinks Aug 1, 2013
e5c680d
unused variable ‘cloned’
sjinks Aug 1, 2013
beba42b
Updated build script
sjinks Aug 1, 2013
2877036
Regenrated builds to make sure everything works
sjinks Aug 1, 2013
99c54ef
Typo fix
sjinks Aug 1, 2013
81ff4a8
Skip tests requiring MySQL if MySQL is not available
sjinks Aug 1, 2013
a9e6946
Merge pull request #970 from sjinks/tests
Aug 1, 2013
2439192
Merge pull request #968 from sjinks/compiler-warnings
Aug 1, 2013
8d51cb3
Adding asserts to String filter
odiel Aug 1, 2013
18a9fe9
Merge pull request #973 from odiel/patch-2
Aug 1, 2013
24c49eb
Adding assert for Email filter
odiel Aug 1, 2013
823dddc
Use PHALCON_THROW_EXCEPTION_STR instead of phalcon_throw_exception_st…
sjinks Aug 1, 2013
0e89f9b
Regexp optimization
sjinks Aug 2, 2013
4d7fa53
Return value optimization
sjinks Aug 2, 2013
e1ebbc6
Regexps are shorter with possesive quantifiers
sjinks Aug 2, 2013
3ff9de2
Introduced phalcon_fetch_property_this(_quick) functions
sjinks Aug 2, 2013
a9c59c4
Optimize Phalcon\Mvc\Router::handle()
sjinks Aug 2, 2013
460be93
Introduced phalcon_array_isset_fetch functions
sjinks Aug 2, 2013
3720315
Optimize Phalcon\Mvc\Router::handle()
sjinks Aug 2, 2013
8e522e3
Merge pull request #977 from sjinks/regexps
Aug 2, 2013
d572b8f
Merge pull request #974 from odiel/patch-2
Aug 2, 2013
d06979d
Merge pull request #976 from sjinks/exceptions
Aug 2, 2013
b59c33d
Fix #980
sjinks Aug 2, 2013
1b2f780
Unit test
sjinks Aug 2, 2013
63a0622
Merge pull request #981 from sjinks/issue-980
Aug 2, 2013
d3f6f53
Bug fixes in phalcon_array_isset_XXX_fetch()
sjinks Aug 3, 2013
e186054
Parentheses around macro definitions
sjinks Aug 3, 2013
af61c2c
Exported phalcon_call_method_vparams()
sjinks Aug 3, 2013
51f3d54
Added phalcon_fetch_nproperty_this(_quick)()
sjinks Aug 3, 2013
0bf82c9
Optimizations in Phalcon\Dispatcher class
sjinks Aug 3, 2013
7a677a4
Implemented #782
sjinks Aug 3, 2013
9c9516e
Unit test
sjinks Aug 3, 2013
5f07965
More optimizations
sjinks Aug 3, 2013
1c5df56
Fix segfault in config.c to let the tests go
sjinks Aug 3, 2013
c4afe0a
Fix segfault when GC is on
sjinks Aug 3, 2013
4389388
Use gc_collect_cycles() in manual-unit.php for more accurate results
sjinks Aug 3, 2013
7f591a2
Fix #987
sjinks Aug 3, 2013
75ee6f9
Merge pull request #984 from sjinks/issue-782
Aug 3, 2013
1be6ab9
Merge pull request #986 from sjinks/segfault-config
Aug 3, 2013
1393ecf
Merge pull request #988 from sjinks/issue-987
Aug 3, 2013
92b4d98
Make sure the test won't fail under Valgrind
sjinks Aug 3, 2013
b87da59
Fix typo in the method name
sjinks Aug 4, 2013
4759bc6
Test case
sjinks Aug 4, 2013
c3baf33
Collections test should work now
sjinks Aug 3, 2013
08f2da9
Merge pull request #997 from sjinks/mongo
Aug 5, 2013
c702360
Merge pull request #990 from sjinks/cache-test
Aug 5, 2013
c800012
Merge pull request #996 from sjinks/annotations_adapter
Aug 5, 2013
3262f9d
Fix #1001
sjinks Aug 5, 2013
53826ae
Regenerated builds [ci skip]
sjinks Aug 5, 2013
3e19d1f
Test case
sjinks Aug 5, 2013
0266ad3
Fix unrelated bug in Phalcon\Config
sjinks Aug 5, 2013
2722cb6
Fix #1000
sjinks Aug 5, 2013
d849918
Merge pull request #1002 from sjinks/issue-1001
Aug 5, 2013
bc4627d
Merge pull request #1003 from sjinks/issue-1000
Aug 5, 2013
ae79e1c
- Adding toArray method to get http response headers as an array
odiel Aug 5, 2013
d5235aa
Merge pull request #1008 from odiel/1.3.0
Aug 5, 2013
40c210f
Added more diagnostics for developer's mode
sjinks Aug 4, 2013
af47c54
Phalcon\Di optimizations
sjinks Aug 4, 2013
07672f8
phalcon_fetch_static_property_ce()
sjinks Aug 4, 2013
934c039
More Phalcon\Di optimizations
sjinks Aug 4, 2013
3c40595
- Adding Response/UnitTest.php from the old Unit Test suite
odiel Aug 5, 2013
e7d066d
Merge pull request #1009 from sjinks/mm
Aug 5, 2013
d42d345
- Adding toArray code to the interface
odiel Aug 5, 2013
017f087
- Renaming to a proper file name
odiel Aug 5, 2013
716dffd
Phalcon\Escaper optimizations
sjinks Aug 4, 2013
f96ec1e
Typo fix [ci skip]
sjinks Aug 4, 2013
a4ff1cd
Merge pull request #1010 from odiel/1.3.0
Aug 5, 2013
0102222
Merge pull request #1014 from sjinks/di
Aug 6, 2013
b290f4b
Merge pull request #1015 from sjinks/escaper
Aug 6, 2013
d39cfb9
Adding latest scanner.re/parser.lemon for PHQL [ci skip]
Aug 6, 2013
5922abc
Fix #1018
sjinks Aug 7, 2013
2c5df2d
Merge pull request #1019 from sjinks/issue-1018
Aug 7, 2013
4e54cac
Fix BUG #1022 for 1.3.0
dreamsxin Aug 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix BUG #1022 for 1.3.0
  • Loading branch information
@dreamsxin
dreamsxin committed Aug 8, 2013
commit 4e54cac47f694f65c45738c9e44248b2569289e6
16 changes: 12 additions & 4 deletions ext/mvc/model.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3094,7 +3094,7 @@ PHP_METHOD(Phalcon_Mvc_Model, _doLowInsert){
zval *attribute_field = NULL, *exception_message = NULL;
zval *value = NULL, *bind_type = NULL, *default_value, *use_explicit_identity;
zval *success, *sequence_name = NULL, *support_sequences;
zval *source, *last_insert_id;
zval *schema, *source, *last_insert_id;
HashTable *ah0;
HashPosition hp0;
zval **hd;
Expand Down Expand Up @@ -3294,11 +3294,19 @@ PHP_METHOD(Phalcon_Mvc_Model, _doLowInsert){
if (phalcon_method_exists_ex(this_ptr, SS("getsequencename") TSRMLS_CC) == SUCCESS) {
phalcon_call_method(sequence_name, this_ptr, "getsequencename");
} else {
PHALCON_INIT_VAR(schema);
phalcon_call_method(schema, this_ptr, "getschema");

PHALCON_INIT_VAR(source);
phalcon_call_method(source, this_ptr, "getsource");

PHALCON_INIT_NVAR(sequence_name);
PHALCON_CONCAT_VSVS(sequence_name, source, "_", identity_field, "_seq");

if (PHALCON_IS_EMPTY(schema)) {
PHALCON_INIT_NVAR(sequence_name);
PHALCON_CONCAT_VSVS(sequence_name, source, "_", identity_field, "_seq");
} else {
PHALCON_INIT_NVAR(sequence_name);
PHALCON_CONCAT_VSVSVS(sequence_name, schema, ".", source, "_", identity_field, "_seq");
}
}
}

Expand Down