Dispatcher getActiveMethod breaks method name letter case

[baryshev]

If method name have one word in prefix like indexAction or addAction everything works fine. But if method have a more complex name like addPostAction or showMeSomethingAction $dispatcher->getActiveMethod() returns unexpected results: addpostAction and showmesomethindAction. Method name before Action keyword unexpectedly lowercased.

It makes impossible to use this methods in annotations reader.

        $annotations = $this->annotations->getMethod(
            $dispatcher->getActiveController(),
            $dispatcher->getActiveMethod()
        );

This code not working, because $dispatcher->getActiveMethod() returns wrong method name (partially lowercased).

OS: Mac OS X 10.9.2
PHP version: 5.5.11
Phalcon version: 1.3.1

[baryshev]

$dispatcher->getActionName() also returns lowercased method name, but without Action postfix.

[dreamsxin]

Case can't control the user to enter the url, so only unified converted to lowercase.

[baryshev]

This naming restrictions makes difficult to develop more complex applications. One word method naming and REST-like routing that strict representing method and class not the only way to make routing.

[baryshev]

Also, $router->addGet('/', 'Posts::addPost'); works fine. I see this problem only with annotations based router.

[dreamsxin]

Understand your meaning this time, I check.

[phalcon]

Try using Phalcon\Mvc\Dispatcher::getActiveMethod instead of getActionName

[baryshev]

There is only one difference between this methods.Phalcon\Mvc\Dispatcher::getActiveMethod returns full method name with Action postfix, Phalcon\Mvc\Dispatcher::getActionName returns only base name of method (without Action postfix). But both returns base method name in lowercase.

Problem not in Phalcon\Mvc\Dispatcher. It's only returns value.
There is some difference between \Phalcon\Mvc\Router\Annotations and \Phalcon\Mvc\Router

$router = new \Phalcon\Mvc\Router();
$router->add(
    "/admin/users/change-password",
    array(
        "controller" => "users",
        "action"     => "changePassword",
    )
);

// Trying to get method name from $dispatcher
$dispatcher->getActiveMethod(); // Returns "changePasswordAction" - everything is fine

$router = new \Phalcon\Mvc\Router\Annotations(false);
$router->addResource('Users', '/');

// Users Controller
class UsersController extends Controller
{
    /**
     * @Route('/admin/users/change-password')
     */
    public function changePasswordAction() {
    }
}

// Trying to get method name from $dispatcher
$dispatcher->getActiveMethod(); // Returns "changepasswordAction" - lowercased method name with 'Action' postfix

In the last example we get unexpected method name. In other words, now we can't get current active method with \Phalcon\Mvc\Router\Annotations router.

[baryshev]

I checked 1.3.2 with @dreamsxin fix. Error was fixed. Thanks!

[clowestab]

This bug is back in 2.0..

[VincentMolinie]

Bug is back in 3.0.1. Could we fix it please ?

[sergeyklay]

@VincentMolinie Could you please open a new issue with minimal code to reproduce