New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Router incorrectly handles numeric controllers/actions #1688

Closed

ghost opened this issue Dec 13, 2013 · 0 comments

ghost commented Dec 13, 2013

$router->add('/admin/:controller', [
  'module'    => 'test',
  'controller'  => 1,
  'action'    => 'index',
]);

$router->add('/admin/:controller/:action', [
  'module'    => 'test',
  'controller'  => 1,
  'action'    => 2,
]);

/admin/controller -- uses Controller controller and the default action, all good
/admin/123 -- uses the default controller and default action instead of 404
/admin/controller/edit -- uses Controller controller and edit action, all good
/admin/controller/123 -- uses Controller controller and the default action instead of 404

http://forum.phalconphp.com/discussion/1288/-router#C4617

The text was updated successfully, but these errors were encountered:

ghost mentioned this issue

Fix #1688 #1694

Merged

phalcon pushed a commit that referenced this issue


          Merge pull request #1694 from sjinks/router

f3808d7

Fix #1688

phalcon closed this as completed

niden added Unassigned and removed Unassigned labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment