Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: PHP crashes without any message when trying mocking classes, inherited from Phalcon\Mvc\Model #16096

Closed
ktsv opened this issue Sep 16, 2022 · 5 comments · Fixed by #16100
Closed

[BUG]: PHP crashes without any message when trying mocking classes, inherited from Phalcon\Mvc\Model #16096

ktsv opened this issue Sep 16, 2022 · 5 comments · Fixed by #16100
Assignees
@Jeckerson
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report external dependency This issue depends on external issue to be resolved.

Comments

@ktsv
Copy link

ktsv commented Sep 16, 2022

[BUG]: PHP crashes without any message when trying mocking classes, inherited from Phalcon\Mvc\Model

Create test, mock any class, inherited from Phalcon\Mvc\Model.

        $this->entity = $this->createMock(Entity::class);

I expect mock to be returned
Actually system fails without any message

  • Phalcon version: 5.0.0RC4
  • PHPunit version 9.5.24
  • Codeception version: 4.2.2
  • PHP Version: 8.0.23
  • Operating System: Debian linux
  • Installation type: Compiling from source
  • Server: Nginx
@ktsv ktsv added bug A bug report status: unverified Unverified labels Sep 16, 2022
@ktsv
Copy link
Author

ktsv commented Sep 16, 2022

this probably happens because some methodh in Phalcon (I was able to find few besides this one) have null as return type

@Jeckerson Jeckerson added 5.0 The issues we want to solve in the 5.0 release external dependency This issue depends on external issue to be resolved. and removed status: unverified Unverified labels Sep 16, 2022
@Jeckerson Jeckerson mentioned this issue Sep 16, 2022
Closed
@Jeckerson
Copy link
Member

Related #16080

@Jeckerson
Copy link
Member

Already fixed in #16080

@Jeckerson Jeckerson moved this to Backlog in Phalcon v5 Sep 17, 2022
@Jeckerson Jeckerson moved this from Backlog to In Progress in Phalcon v5 Sep 17, 2022
@Jeckerson
Copy link
Member

This issue will be used to fix another similar bugs.

Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Update composer.lock
3fe28d1
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Bump ZEPHIR_VERSION to 0.16.3
054de14
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Create separate getter method for transaction property
0768b6f
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Create separate getter methods in Phalcon\Forms\Form class
b2aa4e6
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Add unit test to mock whole Phalcon's codebase
27b6a8f
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Update changelog
4b66a09
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Regenerate ext/ directory
f2a3031
@Jeckerson Jeckerson mentioned this issue Sep 17, 2022
Merged
5 tasks
@Jeckerson Jeckerson linked a pull request Sep 17, 2022 that will close this issue
#16096 - Fix seg faults on class mock #16100
Merged
5 tasks
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Skip test declared classes
50153b2
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Add unset()
fbacba0
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Add unset()
a63d39c
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Replace getMockBuilder() to createMock()
89bdba1
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Mark test as skipped
7a9f53c
Jeckerson added a commit that referenced this issue Sep 17, 2022
@Jeckerson
#16096 - Move MassMockTest outside unit/ directory
00f9f4d
niden added a commit that referenced this issue Sep 18, 2022
@niden
Merge pull request #16100 from phalcon/#16096-mock-seg-fault
edc1f54 
#16096 - Fix seg faults on class mock
@niden
Copy link
Member

niden commented Sep 18, 2022

Resolved in #16100

Thank you @ktsv

@niden niden closed this as completed Sep 18, 2022
Repository owner moved this from In Progress to Implemented in Phalcon v5 Sep 18, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report external dependency This issue depends on external issue to be resolved.
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#16096 - Fix seg faults on class mock phalcon/cphalcon
3 participants
@niden @Jeckerson @ktsv