Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Refactor Crypt/Security namespace #15729

Closed
niden opened this issue Oct 23, 2021 · 1 comment · Fixed by #15748
Closed

[NFR]: Refactor Crypt/Security namespace #15729

niden opened this issue Oct 23, 2021 · 1 comment · Fixed by #15748
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Member

niden commented Oct 23, 2021

Create Encryption namespace
Move Security/Crypt under it
Adjust tests
Align with phalcon
@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Oct 23, 2021
@niden niden self-assigned this Oct 23, 2021
@niden niden mentioned this issue Oct 30, 2021
Closed
niden added a commit to niden-code/phalcon that referenced this issue Oct 30, 2021
@niden
fix(storage/adapter/redis): corrected connection timeout in constructor
703166d 
the `timeout` for the redis connection was incorrectly set to the TTL of each `set`. A new constructor option is available for the `timeout`

phalcon/cphalcon#15729 [#T206]

Refs phalcon#206
niden added a commit to niden-code/phalcon that referenced this issue Oct 30, 2021
@niden
fix(storage/adapter/redis): corrected connection timeout in constructor
58e04ce 
the `timeout` for the redis connection was incorrectly set to the TTL of each `set`. A new constructor option is available for the `timeout`

phalcon/cphalcon#15729 [#T206]

Refs phalcon#206
niden added a commit to phalcon/phalcon that referenced this issue Oct 30, 2021
@niden
fix(storage/adapter/redis): corrected connection timeout in constructor
5b20628 
the `timeout` for the redis connection was incorrectly set to the TTL of each `set`. A new constructor option is available for the `timeout`

phalcon/cphalcon#15729 [#T206]

Refs #206
@niden niden mentioned this issue Oct 31, 2021
Merged
5 tasks
@niden niden linked a pull request Oct 31, 2021 that will close this issue
T15729 crypt security2 #15748
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Oct 31, 2021

Resolved in #15748

@niden niden closed this as completed Oct 31, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15729 crypt security2
1 participant
@niden