Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Inaccuracy in AbstractPdo:lastInsertId() method signature #15659

Closed
Jeckerson opened this issue Sep 11, 2021 · 0 comments · Fixed by #15660
Closed

[BUG]: Inaccuracy in AbstractPdo:lastInsertId() method signature #15659

Jeckerson opened this issue Sep 11, 2021 · 0 comments · Fixed by #15660
Assignees
@Jeckerson
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework

Comments

@Jeckerson
Copy link
Member

Describe the bug
Method lastInsertId() has different signature with original one from Pdo:lastInsertId().

To Reproduce

cphalcon/phalcon/Db/Adapter/Pdo/AbstractPdo.zep

Line 661 in 74298eb

public function lastInsertId(sequenceName = null) -> int | bool

Reference:
https://www.php.net/manual/ru/pdo.lastinsertid.php

public PDO::lastInsertId(?string $name = null): string|false

Expected behavior
Be identical with original.

public function lastInsertId(string! name = null) -> string | bool
@Jeckerson Jeckerson added enhancement Enhancement to the framework bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Sep 11, 2021
@Jeckerson Jeckerson self-assigned this Sep 11, 2021
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Change return type of `Phalcon\Db\Adapter\Pdo\AbstractPdo:cl…
9ba7904 
…ose()` to void
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Change return type of `Phalcon\Db\Adapter\Pdo\AbstractPdo:co…
04ce60b 
…nnect()` to void
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Change signature of `Phalcon\Db\Adapter\Pdo\AbstractPdo:last…
44fde5f 
…InsertId()` to be identical as `Pdo:lastInsertId()`
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Change return type of `Phalcon\Db\Adapter\Pdo\AbstractPdo:co…
054ef34 
…nnect()` to void
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Change return type of `Phalcon\Db\Adapter\Pdo\AbstractPdo:ge…
682f4ff 
…tErrorInfo()` to array
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Remove redundant checks of pdo property in `Phalcon\Db\Ada…
6c61684 
…pter\Pdo\AbstractPdo`
@Jeckerson Jeckerson linked a pull request Sep 11, 2021 that will close this issue
#15659 - Adjust db adapter interface #15660
Merged
5 tasks
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
#15659 - Fix 1st argument name to correct in `AdapterInterface:lastIn…
5eb9212 
…sertId()`
Jeckerson added a commit that referenced this issue Sep 11, 2021
@Jeckerson
Merge pull request #15660 from phalcon/adjust-db-adapter-interface
26111f3 
#15659 - Adjust db adapter interface
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#15659 - Adjust db adapter interface phalcon/cphalcon
1 participant
@Jeckerson