[BUG]: Form filters are not working

[wurst-hans]

Using Phalcon 4.1.0 on PHP 7.4.16 there's an issue with forms using filters.

Sample code:

class SignupController extends Controller
{
    public function indexAction()
    {
        $form = new Form();
        $form->add(
            (new Text('firstname'))
                ->addValidator(
                    new StringLength(
                        [
                            'min' => 5,
                            'messageMinimum' => 'The value is too short',
                        ]
                    )
                )
                ->setFilters([
                    'upper',
                    'trim',
                ])
                ->setLabel('Firstname')
        );
        $form->add(
            new Submit('submit', ['value' => 'Submit'])
        );
        if ($this->request->isPost() && $form->isValid($_POST)) {
            var_dump($this->request->getPost());
            echo "<br>";
            var_dump($form->getValue('firstname'));
            echo "<br>";
        }
        return $this->view
            ->setVars(['form' => $form])
            ->render('sso/signup');
    }
}

When using a short firstname, for example "tom" the validation works and returns an error:

But when using a longer firstname, for example " michael" (with two leading whitespaces!), the validator is satisfied, but the filters aren't applied:

I'm using Di\FactoryDefault and the filters have been executed, see print_r($this->di->get('filter')):

Phalcon\Filter Object
(
    [mapper:protected] => Array
        (
            [absint] => Phalcon\Filter\Sanitize\AbsInt
            [alnum] => Phalcon\Filter\Sanitize\Alnum
            [alpha] => Phalcon\Filter\Sanitize\Alpha
            [bool] => Phalcon\Filter\Sanitize\BoolVal
            [email] => Phalcon\Filter\Sanitize\Email
            [float] => Phalcon\Filter\Sanitize\FloatVal
            [int] => Phalcon\Filter\Sanitize\IntVal
            [lower] => Phalcon\Filter\Sanitize\Lower
            [lowerFirst] => Phalcon\Filter\Sanitize\LowerFirst
            [regex] => Phalcon\Filter\Sanitize\Regex
            [remove] => Phalcon\Filter\Sanitize\Remove
            [replace] => Phalcon\Filter\Sanitize\Replace
            [special] => Phalcon\Filter\Sanitize\Special
            [specialFull] => Phalcon\Filter\Sanitize\SpecialFull
            [string] => Phalcon\Filter\Sanitize\StringVal
            [striptags] => Phalcon\Filter\Sanitize\Striptags
            [trim] => Phalcon\Filter\Sanitize\Trim
            [upper] => Phalcon\Filter\Sanitize\Upper
            [upperFirst] => Phalcon\Filter\Sanitize\UpperFirst
            [upperWords] => Phalcon\Filter\Sanitize\UpperWords
            [url] => Phalcon\Filter\Sanitize\Url
        )
    [services:protected] => Array
        (
            [upper] => Phalcon\Filter\Sanitize\Upper Object
                (
                )
            [trim] => Phalcon\Filter\Sanitize\Trim Object
                (
                )
        )
)

But how to get the filtered values then? Wether in $_POST nor in $form->getValue('firstname') the raw input value has been sanitized.

[BeMySlaveDarlin]

@wurst-hans
First of all, thanks for your report.
Currently Phalcon\Forms\Form::getValue(key) returns raw value and doesn't applies filters you provided.
Filtering is triggered in Phalcon\Forms\Form::bind(data, modelClass, whitelist), when you binding request data to model entity.

@niden we can add (v.5.0.0) new method Phalcon\Forms\Form::getFilteredValue(key), which will give filtered values of request data without binding models.

[wurst-hans]

Thanks for clarification. But that would be great, if filtered values are accessible in any way. In most cases my forms are related to multiple models, so I don't use bind()

[niden]

Resolved in #15759