unset object property makes it private

[konsultaner]

I'm using PHP 7.4 with phalcon 4.1.0. The following code raises an Exception:

$phalconModel->property = "foo";
unset($phalconModel->property); 
$phalconModel->property = "bar"; //<- This throws

Fatal error: Uncaught Phalcon\Mvc\Model\Exception: Cannot access property 'XXX' (not public)

With phalcon 4.0.5 on PHP 7.3 it worked as expected. I'm not sure if this is a PHP issue or Phalcon. You may aswell close it if this is not Phalcon related.

[Jeckerson]

Hello @konsultaner

I can't reproduce your error

$user = User::findFirst(1);
var_dump($user->id); // int(1)
unset($user->id);
var_dump($user->id); // Notice: Access to undefined property User::id

$user->custom = 'value';
var_dump($user->custom); // string(5) "value"
unset($user->custom);
var_dump($user->custom); // Notice: Access to undefined property User::custom

PHP version:
php -v

PHP 7.4.12 (cli) (built: Oct 31 2020 17:04:09) ( NTS )

Phalcon Version:
php -r 'echo Phalcon\Version::get();'

4.0.6

[konsultaner]

ok, that is strange, but this is what happens on my machine. I'll try more investigations on this.

[Jeckerson]

Didn't notice that you are using version 4.1.0. It seems due Zephir version

https://github.com/phalcon/zephir/blob/master/CHANGELOG.md#01218---2020-04-25

Zephir ignored property visibility and has not thrown error when setting private/protected properties in scope that shouldn't
intend for it #2078, #14810, #14766

Try to make properties public, ou use getters

[Jeckerson]

And this is correct PHP behavior, which was fixed after 4.1.0:

<?php

class Test
{
    protected $protected = 1;
    public $public = 2;
    private $private = 3;
}

$class = new Test();

var_dump($class->public);
unset($class->public);
var_dump($class->public); // Notice: Undefined property: Test::$public

unset($class->protected); // Fatal error: Uncaught Error: Cannot access protected property Test::$protected

Sandbox - http://sandbox.onlinephpfunctions.com/code/efae33dd9145a4420dc82e676716d61517d36b2c

[konsultaner]

@Jeckerson I don't know what went wrong, but my field was public, but what I did was:

<?php

class Test extends Model // Its a phalcon model
{
    protected $protected = 1;
    public $public = 2;
    private $private = 3;
}

$class = new Test();

var_dump($class->public);
unset($class->public);
var_dump($class->public); // Notice: Undefined property: Test::$public

$class->public = 3; // Fatal error: Uncaught Phalcon\Mvc\Model\Exception: Cannot access property 'public' (not public)

[Jeckerson]

To fix this, need to review this x2 blocks of code:

        if property_exists(this, property) {
            let manager = this->getModelsManager();

            if unlikely !manager->isVisibleModelProperty(this, property) {
                throw new Exception(
                    "Cannot access property '" . property . "' (not public)."
                );
            }
        }

    final public function isVisibleModelProperty(<ModelInterface> model, string property) -> bool
    {
        var properties, className;

        let className = get_class(model);

        if !isset this->modelVisibility[className] {
            let this->modelVisibility[className] = get_object_vars(model);
        }

        let properties = this->modelVisibility[className];

        return array_key_exists(property, properties);
    }

Unset property will exist even after

<?php

class Test
{
    public $public;
    protected $protected;
    private $private;
}

$test = new Test();

var_dump(property_exists($test, 'public')); // true
unset($test->public);
var_dump(property_exists($test, 'public')); // true

[OliverMensahDev]

@Jeckerson, is someone working on this issue?

[BeMySlaveDarlin]

@Jeckerson, is someone working on this issue?

Im on it, will be fixed asap

[niden]

Resolved in #15719