[Bug] 1.3.0 - adding routes to micro collection

[Cinderella-Man]

Hi,

When adding routes to micro collection, object implementing RouteInterface should be returned but instead of that method returns collection object.

Testcase:

$handler = new RestHandler($this);
$app = new \Phalcon\Mvc\Micro();

$collection = new \Phalcon\Mvc\Micro\Collection();
$collection->setHandler($handler);

$collection->get('/api/siteA', 'find');
$collection->post('/api/siteB', 'save')->setName ('saveRoute');

$app->mount($collection);

$_SERVER['REQUEST_METHOD'] = 'GET';
$_GET['_url'] = '/api/siteA';

$app->handle();

$this->assertTrue($app->getRouter()->wasMatched());
$this->assertEquals(null, $app->getRouter()->getMatchedRoute()->getName());

$_SERVER['REQUEST_METHOD'] = 'POST';
$_GET['_url'] = '/api/siteB';

$app->handle();

$this->assertTrue($app->getRouter()->wasMatched());
$this->assertEquals('saveRoute', $app->getRouter()->getMatchedRoute()->getName());

Thanks in advance for fixing that,

Kamil

[dreamsxin]

Phalcon\Mvc\Micro\Collection::map\get\post is return this.

See #1130 and #1037

When you add routes to the micro collection, those routes are added to that collection and not to the router. Strictly speaking they are not routes — they are just a mapping between the URL and the handler.

@phalcon what do we do with this case?

Your explanation is right, the routes aren't being added to the router so they can't be named.

I'd suggest to close this then :-)