-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Phalcon\Mvc\Model\Row does not fully implement Phalcon\Mvc\Model\ResultsetInterface #1506
Comments
My thought is that echo json_encode(User::findFirst()->toArray()); // works
echo json_encode(User::findFirst($conditions_array)->toArray()); // doesn't work feels inconsistent even though in the first example, the |
Fix #1506 in v1.2.5 add Model\Row::toArray
But did Phalcon\Mvc\Model\Row mean to implement Phalcon\Mvc\Model\ResultsetInterface? As far as I can see, this class implements only two interfaces: ArrayAccess and Phalcon\Mvc\Model\ResultInterface, it does not have any necessary methods to implement ResultsetInterface. @phalcon what do you think? |
Implemented in #1604 |
These work just fine:
However, adding conditions breaks
Model::findFirst()
:The text was updated successfully, but these errors were encountered: