Volt problem with interpreting url_field() function

[sera527]

I think Volt misinterprets the function url_field()

Parse error: syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ',' or ')' in /var/www/html/apps/cache/_var_www_html_apps_frontend_views_client_edit.volt.php on line 131

Provide minimal script to reproduce the issue

{{ url_field("facebook","id": "facebook","class":"form-control") }}

interpreted as

<?= $this->tag->urlField('facebook', 'id' => 'facebook', 'class' => 'form-control') ?>

Details

• Phalcon version: 3.4.0
• PHP Version: 7.1.19
• Operating System: Lubuntu 16.04
• Installation type: installing via package manager
• Server: Apache

[Jurigag]

You forgot about array. Also github is only for NFR and bugs, for questions use forum - https://forum.phalconphp.com

[sera527]

@Jurigag, but the Volt documentation does not contain anything about arrays.

<label for='name'>Name</label>
{{ text_field('name', 'size': 32) }}

https://docs.phalconphp.com/ru/3.3/volt#tag-helpers

[sera527]

@Jurigag also look at this.
This line

{{ tel_field("name","class":"form-control") }}

is interpreted by Volt as

<?= $this->tag->telField(['name', 'class' => 'form-control']) ?>

And this line

{{ url_field("name","class":"form-control") }}

is interpreted by Volt as

<?= $this->tag->urlField('name', 'class' => 'form-control') ?>

Why such difference? I think it's a bug.

[Jurigag]

https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view/engine/volt/compiler.zep#L483 well yea you might actually be right. We need to add it there.

[frsbarbier]

I have the same error with search_field
{{ search_field('name', 'class': 'form-control') }}

Like url_field, search_field is missing in arrayHelpers https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view/engine/volt/compiler.zep#L483

I think it's the same with

color_field
range_field
date_time_field
date_time_local_field
month_field
time_field
week_field

[niden]

This has been addressed with work by @CameronHall

[frsbarbier]

Thanks for this fix but i think search_field was forgotten in arrayHelpers.

[niden]

@frsbarbier I just added it. Nice catch. Thanks!