Fix #2244

phalcon · Mar 29, 2014 · dfcb39b · dfcb39b
1 parent 75276a4
commit dfcb39b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/ext/mvc/model/manager.c b/ext/mvc/model/manager.c
@@ -2270,7 +2270,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Manager, getRelationRecords){
 		RETURN_MM();
 	}
 
-	if (Z_TYPE_P(pre_conditions) != IS_NULL) {
+	if (PHALCON_IS_NOT_EMPTY(pre_conditions)) {
 		PHALCON_INIT_NVAR(conditions);
 		array_init_size(conditions, 1);
 		phalcon_array_append(&conditions, pre_conditions, PH_SEPARATE);

diff --git a/ext/mvc/model/query/builder.c b/ext/mvc/model/query/builder.c
@@ -1777,7 +1777,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, getPhql){
 	 */
 	PHALCON_OBS_VAR(order);
 	phalcon_read_property_this(&order, this_ptr, SL("_order"), PH_NOISY TSRMLS_CC);
-	if (Z_TYPE_P(order) != IS_NULL) {
+	if (PHALCON_IS_NOT_EMPTY(order)) {
 		if (Z_TYPE_P(order) == IS_ARRAY) { 
 
 			PHALCON_INIT_VAR(order_items);

diff --git a/unit-tests/ModelsRelationsTest.php b/unit-tests/ModelsRelationsTest.php
@@ -75,6 +75,7 @@ public function testModelsMysql()
 		$this->_executeTestsNormal($di);
 		$this->_executeTestsRenamed($di);
 		$this->_testIssue938($di);
+		$this->_testIssue2244($di);
 	}
 
 	public function testModelsPostgresql()
@@ -367,4 +368,16 @@ protected function _testIssue938($di)
 			$this->assertEquals($rp[$i]->robots_id, $robot->id);
 		}
 	}
+
+	protected function _testIssue2244($di)
+	{
+		$options = array('order' => '', 'conditions' => '');
+
+		$robot = RelationsRobots::findFirst();
+		$this->assertNotEquals($robot, false);
+
+		$robotsParts = $robot->getRelationsRobotsParts($options);
+		$this->assertEquals(get_class($robotsParts), 'Phalcon\Mvc\Model\Resultset\Simple');
+		$this->assertEquals(count($robotsParts), 3);
+	}
 }