Merge pull request #16574 from niden/T16571-helperfactory-mapper

T16571 helperfactory mapper
phalcon · Apr 29, 2024 · ad6678e · ad6678e
2 parents fdfc87f + 735ce5c
commit ad6678e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG-5.0.md b/CHANGELOG-5.0.md
@@ -4,6 +4,8 @@
 
 ### Changed
 
+- Changed `Phalcon\Support\HelperFactory` to use the internal mapper for better memory management [#16571](https://github.com/phalcon/cphalcon/issues/16571)
+
 ### Added
 
 ### Fixed

diff --git a/phalcon/Support/HelperFactory.zep b/phalcon/Support/HelperFactory.zep
@@ -111,7 +111,12 @@ class HelperFactory extends AbstractFactory
      */
     public function newInstance(string name)
     {
-        return create_instance(this->getService(name));
+        if (true !== isset(this->services[name])) {
+            let this->services[name] = create_instance(this->getService(name));
+        }
+
+        return this->services[name];
+
     }
 
     /**