fix: ensure embedded postgres cleanup in TestMain #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
os.Exit()calls fromTestMainfunctions to allow deferredStop()calls to execute properlyProblem
The
TestMainfunctions in 4 test files were callingos.Exit(code)afterm.Run(). In Go,os.Exit()terminates the program immediately without running deferred functions. This meantdefer sharedEmbeddedPG.Stop()never executed, leaving orphaned postgres processes after each test package run.Solution
Go 1.15+ automatically handles the exit code when
TestMainreturns without callingos.Exit(). By simply removing theos.Exit()calls, the deferred cleanup now executes properly.Ref: golang/go#34129
Test plan
ps aux | grep postgres)go test ./...go build ./...passes