Skip to content

Fix array type handling in IsTextLikeType for USING clause generation #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianzhou merged 3 commits into from
Dec 18, 2025
Merged

Fix array type handling in IsTextLikeType for USING clause generation #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76e9ab8
Initial plan
Copilot Dec 18, 2025
f7f7e5f
fix: handle array types in IsTextLikeType function
Copilot Dec 18, 2025
ab0b6bb
refactor: consolidate array type tests into existing alter_column_typ…
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ir/normalize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,9 @@ func IsTextLikeType(typeName string) bool {
// Normalize the type name for comparison
t := strings.ToLower(typeName)

// Strip array suffix if present
t = strings.TrimSuffix(t, "[]")

// Check for text-like types
switch {
case t == "text":
Expand Down
2 changes: 2 additions & 0 deletions testdata/diff/create_table/alter_column_types/diff.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ ALTER TABLE user_pending_permissions ALTER COLUMN status DROP DEFAULT;
ALTER TABLE user_pending_permissions ALTER COLUMN status TYPE action_type USING status::action_type;

ALTER TABLE user_pending_permissions ALTER COLUMN status SET DEFAULT 'pending';

ALTER TABLE user_pending_permissions ALTER COLUMN tags TYPE action_type[] USING tags::action_type[];
3 changes: 2 additions & 1 deletion testdata/diff/create_table/alter_column_types/new.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ CREATE TABLE public.user_pending_permissions (
permission text NOT NULL,
object_ids_ints bigint[],
action public.action_type,
status public.action_type DEFAULT 'pending'
status public.action_type DEFAULT 'pending',
tags public.action_type[]
);
3 changes: 2 additions & 1 deletion testdata/diff/create_table/alter_column_types/old.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ CREATE TABLE public.user_pending_permissions (
permission text NOT NULL,
object_ids_ints integer[],
action text,
status text DEFAULT 'pending'
status text DEFAULT 'pending',
tags text[]
);