feat: support PG 18 #187
Merged
feat: support PG 18 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the plan to upgrade embedded-postgres to v1.33.0 and add PG18 support, including using version constants instead of hardcoded strings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Upgrade embedded-postgres from v1.32.0 to v1.33.0 - Add PostgreSQL 18 to supported versions (14-18) - Change default test version from PG17 to PG18 - Use embedded-postgres version constants (V14, V15, etc.) instead of hardcoded version strings for automatic updates on library upgrades - Update all documentation and skills to reflect PG18 support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for PostgreSQL 18 by updating the embedded-postgres dependency and configuring the codebase to recognize and test against version 18.
- Updates the embedded-postgres library from v1.32.0 to v1.33.0 to gain PG 18 support
- Changes default PostgreSQL version from 17 to 18 for testing
- Adds PostgreSQL 18 test coverage to the CI/CD release workflow
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates embedded-postgres dependency from v1.32.0 to v1.33.0 |
| go.sum | Updates checksums for the new embedded-postgres version |
| testutil/postgres.go | Adds PG 18 support using embeddedpostgres.V18 constant and changes default version to 18 |
| internal/postgres/embedded.go | Adds case 18 to version mapping function, uses version constants from embedded-postgres |
| .github/workflows/release.yml | Adds PostgreSQL 18 test step to release workflow |
| README.md | Updates version range documentation from "14 through 17" to "14 through 18" |
| docs/faq.mdx | Updates supported versions list to include 18 |
| ir/README.md | Updates compatibility section to list PostgreSQL 18 |
| CLAUDE.md | Updates version range in overview and environment variables documentation |
| .claude/skills/validate_db/SKILL.md | Updates version references in skill documentation |
| .claude/skills/run_tests/SKILL.md | Updates version references and supported versions list |
| .claude/skills/postgres_syntax/SKILL.md | Updates version range in comments and verification checklist |
| .claude/skills/pg_dump/SKILL.md | Updates version references in skill documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #186