Skip to content

Conversation

@tianzhou
Copy link
Contributor

@tianzhou tianzhou commented Dec 2, 2025

Followup #178

Copilot AI review requested due to automatic review settings December 2, 2025 04:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the quotation handling implementation by making the NeedsQuoting function private and removing redundant test cases. This is a follow-up to PR #178 that cleans up the API surface and eliminates test duplication.

Key changes:

  • Made NeedsQuoting function private by renaming it to needsQuoting, as it's only used internally by QuoteIdentifier
  • Removed the redundant TestNeedsQuoting test function, as the private function is fully tested through TestQuoteIdentifier
  • Removed explicit reserved word test cases that were redundant with the dynamic test loop

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ir/quote.go Renamed NeedsQuoting to needsQuoting to make it a private function
ir/quote_test.go Removed TestNeedsQuoting function and redundant explicit reserved word test cases from TestQuoteIdentifier

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tianzhou
Copy link
Contributor Author

tianzhou commented Dec 2, 2025

@Adam-Mustafa

@tianzhou tianzhou merged commit 15d19ac into main Dec 2, 2025
8 checks passed
@tianzhou tianzhou deleted the cleanup branch December 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant