chore: enhance plan schema name replacer #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances schema name normalization during plan generation by adding support for LIKE clauses and aggregate function schemas. When using temporary schemas for plan validation, all schema references must be replaced with the target schema name to ensure generated DDL is valid.
- Added normalization of schema references in table LIKE clauses
- Added normalization of TransitionFunctionSchema and FinalFunctionSchema in aggregates
- Enhanced documentation explaining the schema replacement patterns and rationale
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
cmd/plan/plan.go:1
- The example input on line 594 is missing '.employees' suffix, but the output on line 595 includes it. The input should be 'pgschema_tmp_20251030_154501_123456789.employees' to match the documented pattern being demonstrated.
package plan
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
cc @p-c-h-b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #157