-
Notifications
You must be signed in to change notification settings - Fork 29
fix: non-primitive types qualified #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling custom types (like composite types and enums) from non-pg_catalog schemas in column definitions. It enhances type resolution logic to properly qualify base types from non-standard schemas and introduces a test setup mechanism for tests that require pre-existing types.
Key changes:
- Enhanced SQL queries to handle base types (
typtype = 'b') from schemas other thanpg_catalog - Added
setup.sqlsupport to test infrastructure for pre-creating types/schemas before running diff tests - Created comprehensive test case for adding columns with custom types
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ir/queries/queries.sql |
Added logic to qualify base types from non-pg_catalog/non-table schemas |
internal/diff/diff_test.go |
Added parseSQLWithSetup function and setup.sql file handling for tests |
cmd/migrate_integration_test.go |
Extended integration test to support setup.sql execution and temporary file creation |
testdata/diff/create_table/add_column_custom_type/* |
New test case with setup, old, new, and expected output files |
.claude/skills/pg_dump/SKILL.md |
Added new test command to checklist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4f18d32 to
9d38584
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9d38584 to
59fe651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
59fe651 to
cfc8631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cfc8631 to
022dc4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix #144