chore: consolidate DSN construction #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors database connection logic to use a centralized utility function, promoting code reuse and consistency across the codebase. The changes eliminate duplicated connection string building and ping operations by leveraging the existing util.Connect function.
- Replaced manual DSN construction with
util.ConnectionConfigstruct - Removed redundant ping operations already handled by
util.Connect - Exported
BuildDSNfunction to make it available for potential external use
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/util/connection.go | Exported BuildDSN function by changing it from private buildDSN to public BuildDSN |
| internal/postgres/external.go | Refactored to use util.Connect instead of manual connection setup, removing duplicate ping logic |
| internal/postgres/embedded.go | Refactored two functions to use util.Connect instead of manual connection setup, removing duplicate ping logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tianzhou
force-pushed
the
consolidate_connection
branch
from
d9d8294 to
231e3d6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #141