Skip to content

fix: do not use harded-coded version string #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianzhou merged 1 commit into from
Oct 31, 2025
Merged

fix: do not use harded-coded version string #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions cmd/plan/external_db_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,21 @@ func TestExternalDatabase_CleanupOnError(t *testing.T) {

planHost, planPort, planDatabase, planUser, planPassword := externalPlanDB.GetConnectionDetails()

// Detect the actual major version from the embedded database
conn, _, _, _, _, _ := testutil.ConnectToPostgres(t, externalPlanDB)
defer conn.Close()

majorVersion, err := testutil.GetMajorVersion(conn)
require.NoError(t, err, "should detect PostgreSQL major version")

// Create external database connection with correct version
externalConfig := &postgres.ExternalDatabaseConfig{
Host: planHost,
Port: planPort,
Database: planDatabase,
Username: planUser,
Password: planPassword,
TargetMajorVersion: 17, // Assuming test uses PG 17
TargetMajorVersion: majorVersion,
}

extDB, err := postgres.NewExternalDatabase(externalConfig)
Expand Down Expand Up @@ -174,14 +181,21 @@ func TestExternalDatabase_SchemaIsolation(t *testing.T) {

planHost, planPort, planDatabase, planUser, planPassword := externalPlanDB.GetConnectionDetails()

// Detect the actual major version from the embedded database
conn, _, _, _, _, _ := testutil.ConnectToPostgres(t, externalPlanDB)
defer conn.Close()

majorVersion, err := testutil.GetMajorVersion(conn)
require.NoError(t, err, "should detect PostgreSQL major version")

// Create two external database connections
externalConfig1 := &postgres.ExternalDatabaseConfig{
Host: planHost,
Port: planPort,
Database: planDatabase,
Username: planUser,
Password: planPassword,
TargetMajorVersion: 17,
TargetMajorVersion: majorVersion,
}
extDB1, err := postgres.NewExternalDatabase(externalConfig1)
require.NoError(t, err)
Expand All @@ -193,7 +207,7 @@ func TestExternalDatabase_SchemaIsolation(t *testing.T) {
Database: planDatabase,
Username: planUser,
Password: planPassword,
TargetMajorVersion: 17,
TargetMajorVersion: majorVersion,
}
extDB2, err := postgres.NewExternalDatabase(externalConfig2)
require.NoError(t, err)
Expand Down