chore: suppress test output #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Quiet mode for the apply command to suppress verbose output during test execution. The main purpose is to reduce noise in test logs by suppressing plan displays and progress messages when running schema migrations in automated tests.
Key changes:
- Added a
Quietfield toApplyConfigto control output verbosity - Modified
ApplyMigrationfunction to conditionally suppress plan display, progress messages, and status output - Removed obsolete CLI-based helper functions (
executePlanCommandandexecuteApplyCommand) from schema tests - Updated all test files to enable quiet mode with
Quiet: truein test configurations - Cleaned up verbose logging statements from migration integration tests
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/apply/apply.go | Added Quiet field to ApplyConfig and wrapped all output statements with conditional checks to suppress verbose output when quiet mode is enabled |
| cmd/migrate_integration_test.go | Removed verbose test logging statements and added Quiet: true to applySchemaChanges function |
| cmd/apply/apply_integration_test.go | Added Quiet: true to all test configurations in 7 test functions to suppress output during tests |
| cmd/schema_integration_test.go | Removed unused CLI-based helper functions and updated function calls to use API-based alternatives |
Comments suppressed due to low confidence (1)
cmd/apply/apply.go:157
- This message at line 157 is not wrapped with a
!config.Quietcheck, meaning it will still be printed even when quiet mode is enabled. For consistency with other output suppression in this PR, this should also respect theQuietflag.
fmt.Println("No changes to apply. Database schema is already up to date.")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tianzhou
force-pushed
the
test_case_output
branch
from
c8a1c3e to
aa3055d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.