Skip to content

Conversation

@tianzhou
Copy link
Contributor

Validate #103

Copilot AI review requested due to automatic review settings October 23, 2025 02:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test case for validating NULLIF, GREATEST, and LEAST SQL functions, specifically targeting issue #103 related to divide-by-zero scenarios. The test case verifies that the schema diff tool correctly handles views containing these functions.

Key Changes:

  • Added a new view nullif_functions_view demonstrating NULLIF usage for divide-by-zero protection
  • Includes test coverage for GREATEST, LEAST, and complex CASE expressions with NULLIF
  • Updated test plan files to reflect the addition of the new view

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/diff/create_view/add_view/plan.txt Updated expected plan output to include the new nullif_functions_view
testdata/diff/create_view/add_view/plan.sql Added SQL DDL for the new view to the expected plan SQL
testdata/diff/create_view/add_view/plan.json Added JSON representation of the create operation for the new view
testdata/diff/create_view/add_view/new.sql Added the source SQL definition for nullif_functions_view with comprehensive comments
testdata/diff/create_view/add_view/diff.sql Added the new view to the expected diff output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou merged commit 4c02cec into main Oct 23, 2025
2 checks passed
@tianzhou tianzhou deleted the null_if branch October 23, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant