Skip to content

Conversation

@tianzhou
Copy link
Contributor

@tianzhou tianzhou commented Oct 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 22, 2025 10:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates test cases for SQL view creation and formatting by merging multiple test scenarios into a single comprehensive test suite. The changes eliminate redundant test cases while preserving coverage for array operators, text search functions, and view formatting.

  • Removed duplicate test cases for add_view_coalesce and add_view_array_operators
  • Merged test coverage into the main add_view test case
  • Updated SQL formatting logic to consistently use custom formatter and handle indentation
  • Fixed whitespace normalization in tests to preserve indentation

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/diff/create_view/add_view_coalesce/* Removed entire test case directory (all files deleted)
testdata/diff/create_view/add_view_array_operators/* Removed entire test case directory (all files deleted)
testdata/diff/create_view/add_view/old.sql Merged table schema with additional columns to support consolidated tests
testdata/diff/create_view/add_view/new.sql Merged view definitions for array operators and text search into single test
testdata/diff/create_view/add_view/diff.sql Updated expected diff output with merged view definitions
testdata/diff/create_view/alter_view/diff.sql Fixed formatting to place SELECT on same line as view name
testdata/diff/create_materialized_view/*/diff.sql Simplified WHERE clause formatting (removed explicit type casts)
ir/normalize.go Removed conditional logic for custom formatter, now always uses it
ir/formatter.go Fixed SELECT formatting to place first column on same line; added DISTINCT support
internal/diff/diff_test.go Fixed SQL normalization to preserve indentation while trimming trailing whitespace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou force-pushed the merge_view_test_case branch from 36111d4 to b79fedc Compare October 22, 2025 11:43
@tianzhou tianzhou merged commit c2ee25f into main Oct 22, 2025
2 checks passed
@tianzhou tianzhou deleted the merge_view_test_case branch October 23, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant