Skip to content

Conversation

@tianzhou
Copy link
Contributor

Fix #107

Copilot AI review requested due to automatic review settings October 21, 2025 04:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #107 by ensuring that ignored objects are excluded from fingerprint calculations. The main changes consolidate two database IR retrieval functions into one that always accepts an ignore configuration parameter.

  • Merged GetIRFromDatabase and GetIRFromDatabaseWithIgnoreConfig into a single function
  • Updated fingerprint validation in the apply command to use ignore configuration
  • Enhanced integration tests to verify ignored objects are properly excluded from fingerprints

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
cmd/util/connection.go Consolidated two functions into one GetIRFromDatabase that accepts ignore config parameter; reorganized imports
cmd/plan/plan.go Updated function call to use consolidated GetIRFromDatabase; reorganized imports and removed blank line
cmd/apply/apply.go Added ignore config loading before fingerprint validation and passed it to validation function; removed blank line
cmd/ignore_integration_test.go Expanded test to verify ignored objects are excluded from fingerprint calculation with comprehensive schema and verification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou merged commit c851184 into main Oct 21, 2025
2 checks passed
@tianzhou tianzhou deleted the fingerprint_ignored_files branch October 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fingerprinting tracks ignored files

1 participant