[Feature] Add support for ereport_domain macro#2256
Open
songwdfu wants to merge 1 commit intopgcentralfoundation:developfrom
Open
[Feature] Add support for ereport_domain macro#2256songwdfu wants to merge 1 commit intopgcentralfoundation:developfrom
songwdfu wants to merge 1 commit intopgcentralfoundation:developfrom
Conversation
Support specifying a domain for logs analogous to postgres' ereport_domain macro
songwdfu
changed the title
Contributor
|
This generally looks good. Would you mind also adding some tests around it? we have a If you're up for that, I'm more than happy to merge. |
Author
|
Will do :) Will pin here once done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem
Postgres provides the TEXTDOMAIN macro and ereport_domain macro to allow a domain to be specified for log messages.
It could be read from edata->domain. This might be a feature that people building extensions want to use (or misuse).
Currently pgrx hardcodes the domain as NULL. It would be great if it could provide some way for people to specify it.
Issue here
How does this PR solves this
This is a small PR that modifies the
ErrorReportstruct to add thedomainfield, and defines the ereport_domain macros.