Javascript dependency: Bump @simonwep/pickr from 1.9.1 to 1.10.1 in /web - #10264
Merged
Merged
Conversation
Bumps [@simonwep/pickr](https://github.com/simonwep/pickr) from 1.9.1 to 1.10.1. - [Release notes](https://github.com/simonwep/pickr/releases) - [Commits](simonwep/pickr@1.9.1...v1.10.1) --- updated-dependencies: - dependency-name: "@simonwep/pickr" dependency-version: 1.10.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dpage
added a commit
that referenced
this pull request
Aug 17, 2026
…0.1 in /web (#10264)" (#10278) This reverts commit 34dba5740e0e0e3bb6dd06afe4d84f9e4c0a9a6e. pickr 1.10.1 breaks every dialog carrying a colour field, which includes Register - Server, so the dialog renders as "Something went wrong." and all feature tests time out waiting for its fields. The cause is a dual-package interop change rather than anything in our code. In 1.9.1 the UMD factory ended with "return e = e.default", so module.exports was the Pickr class itself; Babel's _interopRequireDefault saw no __esModule marker, wrapped it, and _pickr.default was the constructor. In 1.10.1 the factory instead returns a namespace object carrying a default getter, still without an __esModule marker, so the wrapper nests it one level deeper and _pickr.default is that namespace object: TypeError: _pickr.default is not a constructor at initPickr (pgadmin/static/js/helpers/withColorPicker.js:69) Nothing in the JS unit tests, eslint or the webpack build can see this, because it only fails when the component mounts, which is why the bump went in with a green board and only the feature tests caught it. Moving to 1.10.1 later is perfectly possible, but it needs the import in withColorPicker.js adapted to the new shape, and it must be validated by opening a dialog rather than by a green Jest run.
dpage
added a commit
that referenced
this pull request
Aug 17, 2026
Two exclusions, both for bumps we have already established we cannot take. pickr 1.10 switched to a dual CJS/ESM build whose CommonJS entry point exports a namespace object rather than the class, so Babel's interop leaves _pickr.default as an object and every dialog carrying a colour field dies on mount. That took master's feature tests down for three days (#10264, reverted in #10278). Because 1.9 -> 1.10 is a minor bump it rejoined the grouped minor-and-patch PR immediately afterwards, buried among twenty other packages, so minor updates are excluded here as well as majors until withColorPicker.js is adapted to the new export shape. Babel 8 requires Node ^22.18.0 || >=24.11.0, whilst Node 20 remains our minimum, and every 8.x package peer-depends on @babel/core ^8.0.0 whilst we are on 7.x. Taking any of them individually, as Dependabot proposed for preset-env, eslint-parser and plugin-syntax-jsx, leaves an unsatisfiable peer requirement and a mixed 7/8 tree. Babel 8 needs a coordinated migration across all ten @babel/* packages once we are on Node 22.
This was referenced Aug 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @simonwep/pickr from 1.9.1 to 1.10.1.
Release notes
Sourced from @simonwep/pickr's releases.
Commits
c5bb5f8Publish v1.10.1810ecddRe-include scss files in npm packagecb5ae3bUpdate urls in package.jsoncd0a6e0Retain umd pickr.min.js version for compatibility reasonsdf920f0Modernize build chain and remove dependencies345091aUpdate demo index.html39b4d82Deploy GitHub pages via ciMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@simonwep/pickrsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)