Skip to content

Conversation

@cvvergara
Copy link
Member

@cvvergara cvvergara commented May 24, 2017

references:

https://trac.osgeo.org/postgis/ticket/3614
https://www.postgresql.org/message-id/flat/1585.1472410329%40sss.pgh.pa.us#1585.1472410329@sss.pgh.pa.us
https://trac.osgeo.org/postgis/changeset/15397
https://github.com/Kitware/CMake/blob/master/Modules/FindPostgreSQL.cmake
https://github.com/pgRouting/pgrouting/blob/master/cmake/FindPostgreSQL.cmake

  • modify the code where applicable to add
#if PSQL_VER > 96
#include float.h'
#endif
  • Modify CMakelists to manipulate the XbetaY, XalphaY, XrcY, versioning names
  • Clean CMakelists of unused code
  • wrap or comment lines 496-L497 wrappers would like:
if(UNIX AND NOT APPLE)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC ")
endif()
  • or
CHECK_C_COMPILER_FLAG("-fPIC" C_COMPILER_SUPPORTS_FPIC)
CHECK_CXX_COMPILER_FLAG("-fPIC" CXX_COMPILER_SUPPORTS_FPIC)
if(C_COMPILER_SUPPORTS_FPIC)
    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC ")
endif()
if(CXX_COMPILER_SUPPORTS_FPIC)
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC ")
endif()
  • fix clangs pragmas
#ifdef __clang__
#pragma clang diagnostic ignored "-pedantic"
#endif
  • fix some pickDeliver test issues on:
    • Appveyor
    • Jenkins
  • Modify tools/winnie/build_pgrouting.sh to reflect the current changes of the build directory where files are copied from to EDB version for testing
  • Appveyor: wrap stdint.h
#if defined(__MINGW32__) && defined(_MSC_VER)
#include stdint.h
#endif
  • wrapper didnt work, not wrapping
  • delete or document directories:
    • sql-scripts (deleted)
  • remove from pick & delivery unused tests for cygwin

@pgRouting/admins

@cvvergara cvvergara added this to the Release 2.5.0 milestone May 24, 2017
@cvvergara cvvergara self-assigned this May 24, 2017
@cvvergara cvvergara requested review from XJTUmg and thisisashukla May 24, 2017 00:57
vidhan13j07
vidhan13j07 previously approved these changes May 24, 2017
vidhan13j07
vidhan13j07 previously approved these changes May 24, 2017
@cvvergara cvvergara changed the title [WIP] Fix/postgres10 Fix/postgres10 May 26, 2017
@cvvergara cvvergara merged commit 13709c3 into pgRouting:develop May 26, 2017
@cvvergara cvvergara deleted the fix/postgres10 branch May 26, 2017 23:22
cvvergara added a commit to cvvergara/pgrouting that referenced this pull request Aug 26, 2021
cvvergara added a commit to cvvergara/pgrouting that referenced this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants