pgtap test use sampledata #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvvergara
force-pushed
the
taptest_use_sampledata_main
branch
from
9544bc1 to
d660007
Compare
Member
Author
|
Update test is here: |
cvvergara
requested review from
cayetanobv,
dkastl,
krashish8,
omshinde and
robe2
robe2
approved these changes
Sep 20, 2023
Member
Author
|
I am double checking everything |
omshinde
approved these changes
Sep 21, 2023
Contributor
omshinde
left a comment
omshinde
left a comment
There was a problem hiding this comment.
I am not sure if I did a proper double checking, however the changes look good to me. Thanks @cvvergara :)
* allpairs * (compare_directed.pg, compare_undirected.pg) => compare_dijkstra.pg * alpha_shape * bdAstar * deleted return_types_check.pg duplicated tests keeping types_check.pg * bdDijkstra * bellman_ford * chinese * circuits * coloring * common * components * contraction * (small_ids.pg, big_ids.pg, super_big_ids.pg) => id_size.pg * dagShortestPath * dominator * lineGraph * max_flow * mincut * ordering * pickDeliver * planar * spanningTree * topologicalSort * topology * transitiveClosure * traversal * trsp * tsp * utilities * version * vrp_basic
* astar * empty_combinations_empty_result.pg => empty_inner_queries_empty_result.pg * new test: compare_dijkstra/combinations.pg * dijkstra * deleted remaining_tests.pg that has duplicated tests * deleted issue_1152.pg that takes too long n time and resources and is not unit test * ksp * withPoints * new tests: allowed_driving_side.pg
cvvergara
force-pushed
the
taptest_use_sampledata_main
branch
from
2e70cc8 to
d31cc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample data changed on june 2022, but the pgtap tests were still executed with the old sample data.
Use sample data from the documentation.
This PR makes use of the new sample data.
Additionally some improvements were done on some tests and small reorgainization on some files
* (small_ids.pg, big_ids.pg, super_big_ids.pg) => id_size.pg