-
-
Notifications
You must be signed in to change notification settings - Fork 377
Bellman Ford - Combinations #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bellman Ford - Combinations #1779
Conversation
|
In the code, two such files were present - For the combinations signature, I made the necessary changes to both such files. |
|
Right now Bellman Ford with negative edges does not exists yet, only positive edges |
cvvergara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked changes, and everything looks fine, Thanks for the missing tests
I will leave here a comment for the future:
- There would be 2 text queries one for positive one for negative edges for the non-combinations signature
- internally what would need to be decided if the second query is for combinations or for negative edges
We will deal with the problem when it shows up
- internally what would need to be decided if the second query is for combinations or for negative edges
Part of #1648
pgr_bellmanFord.pgr_bellmanFord.@pgRouting/admins