Skip to content

aStar family - Combinations SQL #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 17, 2020
Merged

aStar family - Combinations SQL #1732

merged 13 commits into from
Nov 17, 2020

Conversation

@krashish8
Copy link
Member

@krashish8 krashish8 commented Nov 9, 2020 •
edited
Loading

Part of #1648

Adds Combinations signatures to:

  • pgr_astar
    • sql
    • c/c++ code
    • doc query
    • pgtap tests
    • documentation
  • pgr_astarCost
    • sql
    • c/c++ code
    • doc query
    • pgtap tests
    • documentation

@pgRouting/admins

@krashish8 krashish8 added this to the Release 3.2.0 milestone Nov 9, 2020
@krashish8 krashish8 self-assigned this Nov 9, 2020
@krashish8 krashish8 force-pushed the astar-family-combinations branch 3 times, most recently from 6d3c67c to 7a88274 Compare November 14, 2020 05:04
@krashish8 krashish8 marked this pull request as ready for review November 14, 2020 05:19
@krashish8 krashish8 requested a review from cvvergara November 14, 2020 05:20
@dkastl
Copy link
Member

dkastl commented Nov 15, 2020

Thank you @krashish8 ... your contributions look very diligent. I let Vicky check the implementation itself, but I'm glad to see that things like indents and documentation as well as tests are done nicely.

@krashish8 krashish8 force-pushed the astar-family-combinations branch from 7a88274 to fef5a05 Compare November 17, 2020 18:53
@cvvergara
Copy link
Member

cvvergara commented Nov 17, 2020

@krashish8 thanks for the contribution, you can rebase and merge

@krashish8 krashish8 merged commit af0cee2 into pgRouting:develop Nov 17, 2020
@krashish8 krashish8 deleted the astar-family-combinations branch November 17, 2020 19:30
@krashish8 krashish8 mentioned this pull request Dec 15, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvvergara cvvergara cvvergara approved these changes

Assignees

@krashish8 krashish8

Labels

Astar Enhancement Functionality/New

Projects

None yet

Milestone

Release 3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@krashish8 @dkastl @cvvergara