pgRouting 2.2.0 doesn't compiled against PostgreSQL 9.6 head

[robe2]

I just tried compiling 2.2.0 tag release against PostgreSQL 9.6 error and I get this error during compile. I think my dev is okay since compiling against 9.5 works okay.

Scanning dependencies of target vrp_basic
make[2]: Leaving directory `/projects/pgrouting/build'
make -f src/vrp_basic/src/CMakeFiles/vrp_basic.dir/build.make src/vrp_basic/src/CMakeFiles/vrp_basic.dir/build
make[2]: Entering directory `/projects/pgrouting/build'
/c/ming64gcc48/cmake-2.8.11-win32-x86/bin/cmake.exe -E cmake_progress_report /C/ming64gcc48/projects/pgrouting/build/CMakeFiles 51
[ 87%] Building C object src/vrp_basic/src/CMakeFiles/vrp_basic.dir/VRP.c.obj
cd /C/ming64gcc48/projects/pgrouting/build/src/vrp_basic/src && /c/ming64gcc48/mingw64/bin/gcc.exe   -DPGSQL_VERSION=96 -O2  -frounding-math @CMakeFiles/vrp_basic.dir/includes_C.rsp   -o CMakeFiles/vrp_basic.dir/VRP.c.obj   -c /C/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP.c
c:/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP.c: In function 'vrp':
c:/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP.c:886:9: warning: assignment makes pointer from integer without a cast [enabled by default]
   tuple = heap_formtuple(tuple_desc, values, nulls);
         ^
/c/ming64gcc48/cmake-2.8.11-win32-x86/bin/cmake.exe -E cmake_progress_report /C/ming64gcc48/projects/pgrouting/build/CMakeFiles 52
[ 89%] Building CXX object src/vrp_basic/src/CMakeFiles/vrp_basic.dir/VRP_core.cpp.obj
cd /C/ming64gcc48/projects/pgrouting/build/src/vrp_basic/src && /c/ming64gcc48/mingw64/bin/g++.exe    -Ic:/ming64gcc48/projects/CGAL/rel-gmp-5.1.2w64gcc48/include -I/projects/CGAL/rel-mpfr-3.1.2w64gcc48/include -O2  -std=c++0x -frounding-math -Wno-deprecated @CMakeFiles/vrp_basic.dir/includes_CXX.rsp   -o CMakeFiles/vrp_basic.dir/VRP_core.cpp.obj -c /C/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP_core.cpp
In file included from c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/bits/stl_algo.h:66:0,
                 from c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/algorithm:62,
                 from c:/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP_Solver.h:33,
                 from c:/ming64gcc48/projects/pgrouting/branches/2.2.0/src/vrp_basic/src/VRP_core.cpp:30:
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1655:45: error: macro "bind" requires 3 arguments, but only 2 given
     bind(_Func&& __f, _BoundArgs&&... __args)
                                             ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1682:45: error: macro "bind" requires 3 arguments, but only 2 given
     bind(_Func&& __f, _BoundArgs&&... __args)
                                             ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1655:5: error: 'std::bind' declared as an 'inline' variable
     bind(_Func&& __f, _BoundArgs&&... __args)
     ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1655:5: error: template declaration of 'typename std::_Bind_helper<std::__or_<std::is_integral<typename std::decay<_Tp>::type>, std::is_enum<typename std::decay<_Tp>::type> >::value, _Func, _BoundArgs ...>::type std::bind'
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1657:7: error: expected primary-expression before 'typedef'
       typedef _Bind_helper<false, _Func, _BoundArgs...> __helper_type;
       ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1657:7: error: expected '}' before 'typedef'
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1658:24: error: '__helper_type' has not been declared
       typedef typename __helper_type::__maybe_type __maybe_type;
                        ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1658:64: error: invalid type in declaration before ';' token
       typedef typename __helper_type::__maybe_type __maybe_type;
                                                                ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1659:24: error: '__helper_type' has not been declared
       typedef typename __helper_type::type __result_type;
                        ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1659:57: error: invalid type in declaration before ';' token
       typedef typename __helper_type::type __result_type;
                                                         ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1660:7: error: expected unqualified-id before 'return'
       return __result_type(__maybe_type::__do_wrap(std::forward<_Func>(__f)),
       ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1667:15: error: '_Maybe_wrap_member_pointer' does not name a type
       typedef _Maybe_wrap_member_pointer<typename decay<_Func>::type>
               ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1669:24: error: '__maybe_type' has not been declared
       typedef typename __maybe_type::type __functor_type;
                        ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1670:15: error: '_Bind_result' does not name a type
       typedef _Bind_result<_Result,
               ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1682:5: error: 'bind' declared as an 'inline' variable
     bind(_Func&& __f, _BoundArgs&&... __args)
     ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1682:5: error: template declaration of 'typename _Bindres_helper<_Result, _Func, _BoundArgs>::type bind'
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1684:7: error: expected primary-expression before 'typedef'
       typedef _Bindres_helper<_Result, _Func, _BoundArgs...> __helper_type;
       ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1684:7: error: expected '}' before 'typedef'
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1685:24: error: '__helper_type' has not been declared
       typedef typename __helper_type::__maybe_type __maybe_type;
                        ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1685:64: error: invalid type in declaration before ';' token
       typedef typename __helper_type::__maybe_type __maybe_type;
                                                                ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1686:24: error: '__helper_type' has not been declared
       typedef typename __helper_type::type __result_type;
                        ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1686:57: error: invalid type in declaration before ';' token
       typedef typename __helper_type::type __result_type;
                                                         ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1687:7: error: expected unqualified-id before 'return'
       return __result_type(__maybe_type::__do_wrap(std::forward<_Func>(__f)),
       ^
c:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/c++/functional:1689:5: error: expected declaration before '}' token
     }
     ^
src/vrp_basic/src/CMakeFiles/vrp_basic.dir/build.make:85: recipe for target `src/vrp_basic/src/CMakeFiles/vrp_basic.dir/VRP_core.cpp.obj' failed
make[2]: *** [src/vrp_basic/src/CMakeFiles/vrp_basic.dir/VRP_core.cpp.obj] Error 1
make[2]: Leaving directory `/projects/pgrouting/build'
CMakeFiles/Makefile2:810: recipe for target `src/vrp_basic/src/CMakeFiles/vrp_basic.dir/all' failed
make[1]: *** [src/vrp_basic/src/CMakeFiles/vrp_basic.dir/all] Error 2

[robe2]

I tagged this as 2.3.0 release. I can try to hunt down the issue. If you plan to release pgRouting 2.3.0 before September or October, then this can wait till 2.3.0. PostgreSQL 9.6 planned release is in September, but given the haven't pushed out an alpha release yet, I wouldn't be surprised if its not until November or December it comes out.

[robe2]

I am not absolutely sure, but I think you can have travis test against 9.6 if you use a repo that has 9.6.
apt.postgresql.org usually has development branches, though it looks like they haven't pushed out a 9.6 yet. I expect them to when PostgreSQL 9.6 alpha is released.

So I think to add that repo, it would be pretty much like the instructions here:

https://trac.osgeo.org/postgis/wiki/UsersWikiPostGIS22UbuntuPGSQL95Apt

[robe2]

Per @cvvergara suggestion, I remarked out the vpr_basic in the root CMakeLists.txt file and it got further.

2.2.dir/objects.a(one_to_one_dijkstra.c.obj):one_to_one_dijkstra.c:(.text+0x156): undefined reference to `heap_formtuple'
2.2.dir/objects.a(one_to_many_dijkstra.c.obj):one_to_many_dijkstra.c:(.text+0x14d): undefined reference to `heap_formtuple'
2.2.dir/objects.a(many_to_one_dijkstra.c.obj):many_to_one_dijkstra.c:(.text+0x14d): undefined reference to `heap_formtuple'
2.2.dir/objects.a(many_to_many_dijkstra.c.obj):many_to_many_dijkstra.c:(.text+0x15d): undefined reference to `heap_formtuple'
2.2.dir/objects.a(dijkstraVia.c.obj):dijkstraVia.c:(.text+0x16e): undefined reference to `heap_formtuple'
2.2.dir/objects.a(drivedist.c.obj):drivedist.c:(.text+0x13d): more undefined references to `heap_formtuple' follow
ld returned 1 exit status
2.2.dir/build.make:194: recipe for target `lib/libpgrouting-2.2.dll' failed

I think this last error might be that they took out heap_formtuple - alluded to here:

http://www.postgresql.org/message-id/CAM3SWZTXu9LfUx7SR3XN+s2Dos+1Y+pP3E0qgGb5h1Ei89GUEw@mail.gmail.com

I'll see if maybe there is an additional include file we need to put in.

[robe2]

Okay have progress. It seem that function: heap_formtuple was deprecated around 8.3 or 8.4 and heap_form_tuple then came on the scene. In PostgreSQL 9.6 they completely removed heap_formtuple.

Doing a macro replace of heap_formtuple -> heap_form_tuple fixed most of the compile except for the VPR ones.

However I've got a lot of tests failing with errors like:

                                                  'src/withPoints/test/doc-pgr_withPointsDD.test.sql' => 'FAILED: 2,12c2,23
< 1|-1|-1|0|0
< 2|1|1|0.4|0.4
< 3|2|1|0.6|0.6
< 4|5|4|0.3|1.6
< 5|6|8|1|2.6
< 6|8|7|1|2.6
< 7|10|10|1|2.6
< 8|7|6|0.3|3.6
< 9|9|9|1|3.6
< 10|11|11|1|3.6
< 11|13|14|1|3.6
---
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38
> WARNING:  problem in alloc set ExprContext: detected write past chunk end in block 0000000004DF2CC0, chunk 0000000004DF2D38

[robe2]

Now that 9.6 is out in beta, this is more urgent, so I'll try fixing what I can. PostgreSQL 9.6 expected release is September 2016.

[cvvergara]

If I do the changes in master then 2.2.3 has to come out?

[cvvergara]

Can you prepare Jenkins to test master & develop with 9.6?

[cvvergara]

I modified some days ago develop, fixed Astar.

[robe2]

I'm not done fixing yet for PostgreSQL 9.6 to work.

There are a couple of issues. First is the tuple and there are a couple of major regression and the vrp_basic not compiling. I'll try to sort all these out using master and then backport to 2.2.3 if we want 9.6 to work on 2.2.3

Really depends when you plan on releasing 2.3.0

[robe2]

I'll prepare jenkins this weekend.

[cvvergara]

I'll make merge the changes you made into develop, and when you have Jenkins prepared I'll work on what's wrong with vrp_basic