week 8 sloan ordering

[bipashabg]

Fixes # .

Changes proposed in this pull request:

• Begin writing the rest of pgTap tests.
• Write no_crash_test.pg
• Write inner_query,pg
• Modify structure of return queries according to mentor's feedback
• Remove unrequired testing queries
• Mark todo for unsure test queries
• Create edge_cases.pg

@pgRouting/admins

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cvvergara]

Found the error, was my typo:
before

-- 0 edge, 0 vertex test
PREPARE iq1 AS
SELECT id, source, target, cost, reverse_cost
FROM edges WHERE id > 18;

PREPARE q1 AS
SELECT * FROM pgr_sloanOrdering('q1');  <--- I had this

after

-- 0 edge, 0 vertex test
PREPARE iq1 AS
SELECT id, source, target, cost, reverse_cost
FROM edges WHERE id > 18;

PREPARE q1 AS
SELECT * FROM pgr_sloanOrdering('iq1');   < -- this is corrected

I was also thinking ... This is simpler:

PREPARE q1 AS
SELECT * FROM pgr_sloanOrdering(
  'SELECT id, source, target, cost, reverse_cost FROM edges WHERE id > 18');

So for the tests that you are rewriting from Cuthill Mckee you can just have the prepare statement with the appropiate inner query.

Don't forget to write in the comment the code for graphviz example

-- Two isolated vertices: 3 -- 3; 7 -- 7;

Put in the main comment of this PR all the tasks I told you to do, it will help to keep track.

[bipashabg]

Tasks for this week:

• Write no_crash_test.pg
• Write inner_query.pg
• In edge_cases.pg remove queries which are not needed
• Understand what PREPARE and $$ mean in the queries
• Test for no edges
• Remove create table command from edge_cases.pg
• Change is_empty to throws_ok
• Modify number of planned tests
• Analyse code to determine which tests to run for sloan ordering only
• Mark todo to unsure test queries like ordering for disconnected graphs
• Test for two isolated and connected graphs
• Examine the return queries

For -- Two isolated vertices: 3 -- 3; 7 -- 7;
PREPARE iq5 AS SELECT id, source, source AS target, cost, reverse_cost FROM edges WHERE id = 7 UNION SELECT id, target AS source, target, cost, reverse_cost FROM edges WHERE id = 7;