Skip to content

Conversation

@wifiBlack
Copy link

@wifiBlack wifiBlack commented Jul 21, 2025

Changes proposed in this pull request:

  • Refactored kingOrdering and minDegreeOrdering to correctly map output using vertex IDs instead of internal indices.
  • Replaced exception-based error handling with PostgreSQL-friendly NOTICE messages and graceful early returns.
  • Introduced comprehensive SQL and pgTAP test coverage:
    • Edge case and crash-resilience tests for both algorithms.
    • Added inner query tests with PostgreSQL version checks.
  • Cleaned up and fixed test SQL files to ensure both algorithms now return valid, testable results.
  • Removed incorrect table setup code from kingOrdering.pg.

@pgRouting/admins

@wifiBlack wifiBlack added the wifi-2025 Done by Fan Wu label Jul 25, 2025
@wifiBlack wifiBlack added this to the 2025 second period milestone Jul 25, 2025
@wifiBlack wifiBlack merged commit 839599e into pgRouting:wifi-2025 Jul 28, 2025
18 of 19 checks passed
@pgRouting pgRouting deleted a comment from coderabbitai bot Jul 30, 2025
@pgRouting pgRouting deleted a comment from coderabbitai bot Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wifi-2025 Done by Fan Wu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant